svn commit: r244112 - head/sys/kern

[Adrian Chadd]

On 12 December 2012 23:19, Navdeep Parhar <nparhar at gmail.com> wrote:
> On Wed, Dec 12, 2012 at 11:07:58PM -0800, Adrian Chadd wrote:
>> Andriy,
>>
>> If you are willing to enable INVARIANTS by default in GENERIC, right
>> now, then I think we should remove Alfred's work.
>
> It's already enabled by default in GENERIC in the development branch
> (aka head), which is exactly the right thing to do.  Surely, you're not
> advocating we enable it by default in any release branch?

I'm sure at least one vendor out there would love to ship GENERIC +
INVARIANTS minus the panic bit, so they get all of the invariants
reporting and checking, but none of the panicing (which wouldn't occur
if INVARIANTS wasn't compiled in.)

WITNESS is still slow, but after I fixed a rather hilarious strlen()
abuse in it, it actually started to be more useful to enable at
runtime on my test equipment by default. Before I fixed that strlen()
issue, I couldn't get anywhere near line rate ethernet/wifi
throughput, so I didn't want to leave it on.


Adrian