svn commit: r238563 - head/gnu/usr.bin/groff/tmac
Simon J. Gerraty
sjg at juniper.net
Tue Aug 21 05:46:19 UTC 2012
On Mon, 30 Jul 2012 11:19:48 -0400, John Baldwin writes:
>> @@ -68,7 +68,7 @@ beforeinstall:
>> cd ${.CURDIR}; \
>> ${INSTALL} -o ${TMACOWN} -g ${TMACGRP} -m ${TMACMODE} \
>> koi8-r.tmac hyphen.ru ${DESTDIR}${TMACDIR}
>> - cd ${.OBJDIR}
>> + cd ${.OBJDIR};
>
>Isn't this a nop now? That is, it changes the working directory in a temporar
>y
>shell that immediately exits?
If a shell is used, yes.
Even in compat mode, bmake attempts to avoid the shell, so absent a clue
(like ';') it attempts - and fails direct exection.
A cd like that by itself generally makes no sense (as everyone has noted
;-)
The ';' was a minimal change to ensure consistent behavior b/w the two
makes, but re-working the target to avoid the need for that cd would be
better - as noted just now in response to Ruslan.
Thanks
--sjg
More information about the svn-src-all
mailing list