svn commit: r221053 - head/usr.bin/rlogin

[John Baldwin]

On Wednesday, April 27, 2011 3:35:50 pm David O'Brien wrote:
> On Wed, Apr 27, 2011 at 10:48:33AM -0400, John Baldwin wrote:
> > For changing WARNS, 'make universe' works well
> 
> I have to disagree.  Due to its silent failing, it is only suitable for
> what PHK added it for -- "what if" changes.
> [Message-ID: <13101.1227520743 at critter.freebsd.dk>]
> 
> One has to do all the various greps of the output in order to be
> confident of their belief of the results.
> 
> We really need a new target that builds more normal (fails on first
> error) and makes it obvious when there is a failure.

make tinderbox already does this.  It gives you a nice summary at the end if 
anything failed.  If things do fail, yes, you have to look in the listed files 
to find the errors, but 'make tinderbox' tells you exactly which files to 
check.  For example:

--------------------------------------------------------------
>>> make universe completed on Wed Apr 27 15:05:23 EDT 2011
                      (started Wed Apr 27 14:09:08 EDT 2011)
--------------------------------------------------------------
Tinderbox failed:
mips AR71XX kernel failed, check _.mips.AR71XX for details
mips MALTA64 kernel failed, check _.mips.MALTA64 for details
....

-- 
John Baldwin