svn commit: r212993 - head/sys/dev/acpica

[Andriy Gapon]

Author: avg
Date: Wed Sep 22 06:10:22 2010
New Revision: 212993
URL: http://svn.freebsd.org/changeset/base/212993

Log:
  acpi_attach: do not explicitly install default handlers for default
  address spaces
  
  There has been no need to do that starting with ACPICA 20040427 as
  AcpiEnableSubsystem() installs the handlers automatically.
  Additionaly, explicitly calling AcpiInstallAddressSpaceHandler before
  AcpiEnableSubsystem is not supported by ACPICA and leads to too early
  execution of _REG methods in some DSDTs, which may result in problems.
  
  Big thanks to Robert Moore of ACPICA/Intel for explaining the above.
  
  Reported by:	Daniel Bilik <daniel.bilik at neosystem.cz>
  Tested by:	Daniel Bilik <daniel.bilik at neosystem.cz>
  Reviewed by:	jkim
  Suggested by:	"Moore, Robert" <robert.moore at intel.com>
  MFC after:	1 week

Modified:
  head/sys/dev/acpica/acpi.c

Modified: head/sys/dev/acpica/acpi.c
==============================================================================
--- head/sys/dev/acpica/acpi.c	Wed Sep 22 05:32:37 2010	(r212992)
+++ head/sys/dev/acpica/acpi.c	Wed Sep 22 06:10:22 2010	(r212993)
@@ -494,29 +494,6 @@ acpi_attach(device_t dev)
     acpi_enable_pcie();
 #endif
 
-    /* Install the default address space handlers. */
-    status = AcpiInstallAddressSpaceHandler(ACPI_ROOT_OBJECT,
-		ACPI_ADR_SPACE_SYSTEM_MEMORY, ACPI_DEFAULT_HANDLER, NULL, NULL);
-    if (ACPI_FAILURE(status)) {
-	device_printf(dev, "Could not initialise SystemMemory handler: %s\n",
-		      AcpiFormatException(status));
-	goto out;
-    }
-    status = AcpiInstallAddressSpaceHandler(ACPI_ROOT_OBJECT,
-		ACPI_ADR_SPACE_SYSTEM_IO, ACPI_DEFAULT_HANDLER, NULL, NULL);
-    if (ACPI_FAILURE(status)) {
-	device_printf(dev, "Could not initialise SystemIO handler: %s\n",
-		      AcpiFormatException(status));
-	goto out;
-    }
-    status = AcpiInstallAddressSpaceHandler(ACPI_ROOT_OBJECT,
-		ACPI_ADR_SPACE_PCI_CONFIG, ACPI_DEFAULT_HANDLER, NULL, NULL);
-    if (ACPI_FAILURE(status)) {
-	device_printf(dev, "could not initialise PciConfig handler: %s\n",
-		      AcpiFormatException(status));
-	goto out;
-    }
-
     /*
      * Note that some systems (specifically, those with namespace evaluation
      * issues that require the avoidance of parts of the namespace) must