svn commit: r212808 - stable/7/usr.bin/gzip

[Xin LI]

Author: delphij
Date: Sat Sep 18 00:46:05 2010
New Revision: 212808
URL: http://svn.freebsd.org/changeset/base/212808

Log:
  MFC r211475:
  
  Check return value of dup(), it could be -1 when the system is running
  out of file descriptors for instance.
  
  Found with:	Coverity Prevent(tm)
  CID:		6084

Modified:
  stable/7/usr.bin/gzip/unpack.c
Directory Properties:
  stable/7/usr.bin/gzip/   (props changed)

Modified: stable/7/usr.bin/gzip/unpack.c
==============================================================================
--- stable/7/usr.bin/gzip/unpack.c	Sat Sep 18 00:44:55 2010	(r212807)
+++ stable/7/usr.bin/gzip/unpack.c	Sat Sep 18 00:46:05 2010	(r212808)
@@ -312,7 +312,14 @@ unpack(int in, int out, char *pre, size_
 {
 	unpack_descriptor_t	unpackd;
 
-	unpack_parse_header(dup(in), dup(out), pre, prelen, bytes_in, &unpackd);
+	in = dup(in);
+	if (in == -1)
+		maybe_err("dup");
+	out = dup(out);
+	if (out == -1)
+		maybe_err("dup");
+
+	unpack_parse_header(in, out, pre, prelen, bytes_in, &unpackd);
 	unpack_decode(&unpackd, bytes_in);
 	unpack_descriptor_fini(&unpackd);