svn commit: r213765 - head/sys/dev/aic7xxx/aicasm

[Jung-uk Kim]

On Thursday 14 October 2010 03:05 pm, Jung-uk Kim wrote:
> On Thursday 14 October 2010 01:06 pm, John Baldwin wrote:
> > On Thursday, October 14, 2010 12:41:45 pm Dmitry Morozovsky wrote:
> > > On Thu, 14 Oct 2010, John Nielsen wrote:
> > >
> > > JN> >> I'm migrating a box from 8-STABLE to -CURRENT this
> > > morning and this JN> >> commit seems to break buildkernel:
> > > JN> >>
> > > JN> >> cc -O2 -pipe -nostdinc -I/usr/include -I.
> > > JN> >> -I/usr/src/sys/dev/aic7xxx/aicasm -std=gnu99
> > > -Wsystem-headers JN> >> -Werror -Wall -Wno-format-y2k -W
> > > -Wno-unused-parameter JN> >> -Wstrict-prototypes
> > > -Wmissing-prototypes -Wpointer-arith JN> >> -Wreturn-type
> > > -Wcast-qual -Wwrite-strings -Wswitch -Wshadow JN> >>
> > > -Wunused-parameter -Wcast-align -Wno-pointer-sign -c
> > > aicasm_scan.c JN> >> cc1: warnings being treated as errors
> > > JN> >> /usr/src/sys/dev/aic7xxx/aicasm/aicasm_scan.l:840:
> > > warning: JN> >> function declaration isn't a prototype ***
> > > Error code 1 JN> >>
> > > JN> >> I don't have any custom CFLAGS, etc defined. Commenting
> > > out the new JN> >> #defines from this patch allows the build to
> > > continue. JN> >>
> > > JN> >> I'm guessing this doesn't happen on machines already
> > > running JN> >> -CURRENT or tinderbox (and others) would have
> > > noticed. However if JN> >> this is (going to be) a supported
> > > upgrade path from 8.x to 9.0 JN> >> perhaps there's a way to
> > > make both clang and gcc from 8.x happy? JN> >
> > > JN> > If you want to upgrade from N to N+1, "make buildworld"
> > > is required. JN>
> > > JN> Sorry, I did do a "make buildworld" (which succeeded) prior
> > > to the "make buildkernel" (which failed as I described).
> > >
> > > I can confirm this: my build machine, which is
> > >
> > > FreeBSD beaver.rinet.ru 8.1-STABLE FreeBSD 8.1-STABLE #1
> > > r213380M: Sun Oct  3 13:25:15 MSD 2010
> > >
> > > is now failing 'buildworld buildkernel __MAKE_CONF=/dev/null'
> > > for HEAD sources both for TARGET=amd64 and i386
> >
> > The tinderboxes are also failing (at least sun4v).
>
> No, it's fixed already:
>
> http://svn.freebsd.org/viewvc/base?view=revision&revision=213764

I should have said lex(1) was fixed first, then aicasm_scan.l was 
changed.  I guess there was a brief inconsistency in tinderbox 
environment.  Shrug...

Jung-uk Kim