svn commit: r205810 - stable/8/sys/net

[Ed Maste]

Author: emaste
Date: Mon Mar 29 00:08:58 2010
New Revision: 205810
URL: http://svn.freebsd.org/changeset/base/205810

Log:
  MFC r205411:
  
    Avoid holding the VLAN_LOCK() over the parent interface SIOCGIFMEDIA
    ioctl call, as it may sleep.
  
    Reviewed by:    rwatson

Modified:
  stable/8/sys/net/if_vlan.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)
  stable/8/sys/dev/xen/xenpci/   (props changed)

Modified: stable/8/sys/net/if_vlan.c
==============================================================================
--- stable/8/sys/net/if_vlan.c	Sun Mar 28 22:46:56 2010	(r205809)
+++ stable/8/sys/net/if_vlan.c	Mon Mar 29 00:08:58 2010	(r205810)
@@ -1335,9 +1335,9 @@ vlan_ioctl(struct ifnet *ifp, u_long cmd
 	case SIOCGIFMEDIA:
 		VLAN_LOCK();
 		if (TRUNK(ifv) != NULL) {
-			error = (*PARENT(ifv)->if_ioctl)(PARENT(ifv),
-					SIOCGIFMEDIA, data);
+			p = PARENT(ifv);
 			VLAN_UNLOCK();
+			error = (*p->if_ioctl)(p, SIOCGIFMEDIA, data);
 			/* Limit the result to the parent's current config. */
 			if (error == 0) {
 				struct ifmediareq *ifmr;