svn commit: r216355 - head/sys/dev/ieee488

[Joerg Wunsch]

Author: joerg
Date: Fri Dec 10 14:04:41 2010
New Revision: 216355
URL: http://svn.freebsd.org/changeset/base/216355

Log:
  Fix __retval vs. retval confusion: retval is meant to store the (userland)
  pointer where data is to be returned by ibask() (currently unimplemented),
  while __retval holds the value returned by the libgpib ibfoo() functions.
  
  The confusion resulted in the ibfoo() functions returning an uninitialized
  value except in situations where the GPIB activity has been terminated
  abnormally.
  
  MFC after:	3 days

Modified:
  head/sys/dev/ieee488/ibfoo.c

Modified: head/sys/dev/ieee488/ibfoo.c
==============================================================================
--- head/sys/dev/ieee488/ibfoo.c	Fri Dec 10 11:02:59 2010	(r216354)
+++ head/sys/dev/ieee488/ibfoo.c	Fri Dec 10 14:04:41 2010	(r216355)
@@ -1019,7 +1019,7 @@ gpib_ib_ioctl(struct cdev *dev, u_long c
 	ap->__iberr = 0;
 	ap->__ibsta = 0;
 	ap->__ibcnt = 0;
-	ap->retval = 0;
+	ap->__retval = 0;
 
 	if (ap->__field & __F_TMO) {
 		if (ap->tmo < 0 || ap->tmo >= max_timeouts)