svn commit: r211530 - head/sys/netinet6

[Hajimu UMEMOTO]

Hi,

>>>>> On Fri, 20 Aug 2010 22:19:37 +0400
>>>>> pluknet <pluknet at gmail.com> said:

pluknet> I think it still continues to test the remain condition
pluknet> regardless of test result of the first part (!optp).

No, I don't think my fix is wrong.  If the evaluation matches, the
latter should not be evaluated.

pluknet> That should work:

pluknet>  -               if (!optp->ip6po_pktinfo || !optp->ip6po_pktinfo->ipi6_ifindex)
pluknet>  +               if (optp != NULL && (!optp->ip6po_pktinfo ||
pluknet>  +                   !optp->ip6po_pktinfo->ipi6_ifindex))

With your proposal, when optp is NULL, use_defzone doesn't set.  It is
not desired thing.

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume at mahoroba.org  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/