svn commit: r191717 - head/sys/dev/ata

[Alexander Motin]

Poul-Henning Kamp wrote:
> In message <200905010803.n4183kGE036016 at svn.freebsd.org>, Alexander Motin write
> s:
> 
>>   - Drop pre-dump requests queue on dumping. ATA code, working in dumping
>>  (interruptless) mode, unable to handle long request queue. Actually, to get
>>  coherent dump we anyway should do as few unrelated actions as possible.
> 
> It seems a wrong tradeoff to me, to favour dump fidelity over filesystem
> coherence.

When dump is disabled, queued requests are trashed anyway. Dump does not 
make the things worse then they are. It just does it's duty as good as 
possible and as simple as possible.

There is no any warranty that completing all queued requests will make 
filesystem more coherent, it easily can happen opposite. Also, as soon 
as current system state is known to be invalid (as kernel has just 
panicked), it could be safer do not try to make any excessive movements.

-- 
Alexander Motin