svn commit: r188457 - head/sys/dev/bge

[Zhang, Helen]

Thank Marius for checking in the code.

I ran into the problem mainly because mii driver was
not hooked properly, so mii_phy_probe() function failed.

-Helen

-----Original Message-----
From: Marius Strobl [mailto:marius at alchemy.franken.de] 
Sent: Wednesday, February 11, 2009 2:17 PM
To: Coleman Kane
Cc: src-committers at FreeBSD.org; svn-src-all at FreeBSD.org;
svn-src-head at FreeBSD.org; Zhang, Helen
Subject: Re: svn commit: r188457 - head/sys/dev/bge

On Tue, Feb 10, 2009 at 05:09:47PM -0500, Coleman Kane wrote:
> On Tue, 2009-02-10 at 21:54 +0000, Marius Strobl wrote:
> > Author: marius
> > Date: Tue Feb 10 21:54:23 2009
> > New Revision: 188457
> > URL: http://svn.freebsd.org/changeset/base/188457
> > 
> > Log:
> >   Don't reset the PHY probe retry counter within the loop so
> >   it will eventually terminate as intended.
> >   
> >   Submitted by:	Helen Zhang
> > 
> > Modified:
> >   head/sys/dev/bge/if_bge.c
> > 
> > Modified: head/sys/dev/bge/if_bge.c
> >
========================================================================
======
> > --- head/sys/dev/bge/if_bge.c	Tue Feb 10 21:51:33 2009
(r188456)
> > +++ head/sys/dev/bge/if_bge.c	Tue Feb 10 21:54:23 2009
(r188457)
> > @@ -2674,11 +2674,11 @@ bge_attach(device_t dev)
> >  		 * if we get a conflict with the ASF firmware accessing
> >  		 * the PHY.
> >  		 */
> > +		trys = 0;
> >  		BGE_CLRBIT(sc, BGE_MODE_CTL, BGE_MODECTL_STACKUP);
> >  again:
> >  		bge_asf_driver_up(sc);
> >  
> > -		trys = 0;
> >  		if (mii_phy_probe(dev, &sc->bge_miibus,
> >  		    bge_ifmedia_upd, bge_ifmedia_sts)) {
> >  			if (trys++ < 4) {
> > 
> 
> I'm curious... I recent ran into a problem where this driver was not
> properly recovering from an ACPI resume event (under amd64 with some
> patches). I am curious if this patch might fix that problem... as the
> death happened somewhere around here.

I doubt that.

> 
> What example case did you use to discover this bug?
> 

You'd need to ask Helen (CC'ed) regarding this.

Marius