svn commit: r188452 - head/sys/netgraph/bluetooth/socket
Maksim Yevmenkin
emax at FreeBSD.org
Tue Feb 10 12:27:07 PST 2009
Author: emax
Date: Tue Feb 10 20:27:05 2009
New Revision: 188452
URL: http://svn.freebsd.org/changeset/base/188452
Log:
Update comment. soalloc() is no longer performing M_WAITOK memory allocations.
Submitted by: ru
MFC after: 3 days
Modified:
head/sys/netgraph/bluetooth/socket/ng_btsocket_rfcomm.c
Modified: head/sys/netgraph/bluetooth/socket/ng_btsocket_rfcomm.c
==============================================================================
--- head/sys/netgraph/bluetooth/socket/ng_btsocket_rfcomm.c Tue Feb 10 20:08:03 2009 (r188451)
+++ head/sys/netgraph/bluetooth/socket/ng_btsocket_rfcomm.c Tue Feb 10 20:27:05 2009 (r188452)
@@ -518,13 +518,9 @@ ng_btsocket_rfcomm_connect(struct socket
return (EDESTADDRREQ);
/*
- * XXX FIXME - This is FUBAR. socreate() will call soalloc(1), i.e.
- * soalloc() is allowed to sleep in MALLOC. This creates "could sleep"
- * WITNESS warnings. To work around this problem we will create L2CAP
- * socket first and then check if we actually need it. Note that we
- * will not check for errors in socreate() because if we failed to
- * create L2CAP socket at this point we still might have already open
- * session.
+ * Note that we will not check for errors in socreate() because
+ * if we failed to create L2CAP socket at this point we still
+ * might have already open session.
*/
error = socreate(PF_BLUETOOTH, &l2so, SOCK_SEQPACKET,
@@ -857,13 +853,9 @@ ng_btsocket_rfcomm_listen(struct socket
mtx_unlock(&pcb->pcb_mtx);
/*
- * XXX FIXME - This is FUBAR. socreate() will call soalloc(1), i.e.
- * soalloc() is allowed to sleep in MALLOC. This creates "could sleep"
- * WITNESS warnings. To work around this problem we will create L2CAP
- * socket first and then check if we actually need it. Note that we
- * will not check for errors in socreate() because if we failed to
- * create L2CAP socket at this point we still might have already open
- * session.
+ * Note that we will not check for errors in socreate() because
+ * if we failed to create L2CAP socket at this point we still
+ * might have already open session.
*/
socreate_error = socreate(PF_BLUETOOTH, &l2so, SOCK_SEQPACKET,
More information about the svn-src-all
mailing list