svn commit: r200205 - stable/8/etc

[Hiroki Sato]

Doug Barton <dougb at FreeBSD.org> wrote
  in <4B28181B.5070503 at FreeBSD.org>:

do> You apparently merged your change from r197144 without applying my fix
do> for this problem above from r198162, which broke this feature in
do> 8-stable. See http://www.freebsd.org/cgi/query-pr.cgi?pr=141642
do>
do> In my mind breaking this feature in a -stable branch is a fairly
do> serious error, and adds fuel to my growing discomfort about the
do> changes you've been making in /etc. How do you suggest that we move
do> forward and at the same time lessen the potential for further problems?

 I am really sorry for breaking it again.  My intention was to merge
 only changes of set_rcvar* on a request, but I mistakenly included
 the line you fixed after I committed the original change.  It is
 totally my fault.  Sorry.

 I think I will add regression tests for checking rc.d functionality
 before merging other changes I made on -HEAD.  The rc.d scripts are
 used in various ways now and there are some ambiguous definitions and
 inconsistency such as a way to set the default value to a variable,
 naming conventions, and so on, so for that we may need to define what
 are correct/acceptable ones.  Anyway, I start trying to do so and
 this should help to prevent further inappropriate changes (in terms
 of whether the existing functionality is broken or not) from being
 added.

-- Hiroki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20091216/aad21510/attachment.pgp