svn commit: r186529 - head/sys/dev/acpi_support

[Stanislav Sedov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sat, 27 Dec 2008 20:50:55 -0800
Andrew Thompson <thompsa at FreeBSD.org> mentioned:

> On Sat, Dec 27, 2008 at 08:48:11PM +0000, Stanislav Sedov wrote:
> > Author: stas
> > Date: Sat Dec 27 20:48:11 2008
> > New Revision: 186529
> > URL: http://svn.freebsd.org/changeset/base/186529
> > 
> > Log:
> >   - Fix incorrect array declaration that was causing the stack overflow
> >     on some (most?) Asus laptops.
> >   
> >   Discussed with:	rpaulo
> >   Approved by:	kib (mentor)
> >   MFC after:	2 weeks
> > 
> > Modified:
> >   head/sys/dev/acpi_support/acpi_asus.c
> > 
> > Modified: head/sys/dev/acpi_support/acpi_asus.c
> > ==============================================================================
> > --- head/sys/dev/acpi_support/acpi_asus.c	Sat Dec 27 20:37:53 2008	(r186528)
> > +++ head/sys/dev/acpi_support/acpi_asus.c	Sat Dec 27 20:48:11 2008	(r186529)
> > @@ -976,7 +976,7 @@ acpi_asus_sysctl_set(struct acpi_asus_so
> >  {
> >  	ACPI_STATUS		status = AE_OK;
> >  	ACPI_OBJECT_LIST 	acpiargs;
> > -	ACPI_OBJECT		acpiarg[0];
> > +	ACPI_OBJECT		acpiarg[1];
> >  
> >  	ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__);
> >  	ACPI_SERIAL_ASSERT(asus);
> 
> Thanks! I have had panics that I think are related to this.
> 

I wonder how does gcc allowed this. It emits warnings only in
pedantic mode which we cannot use to compile kernel with.

Coverity is also calm about this issue.

- -- 
Stanislav Sedov
ST4096-RIPE
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iEYEARECAAYFAklX0+UACgkQK/VZk+smlYEhJQCfc1cQKsaC1WufslPzh6A2Ys4f
V9gAn0ctgYE++vyx/6dVJWI0EEYm6H0a
=G9UK
-----END PGP SIGNATURE-----

!DSPAM:4957d16c967001291218750!