svn commit: r186337 - head/usr.sbin/burncd
David O'Brien
obrien at freebsd.org
Tue Dec 23 18:23:15 UTC 2008
On Sun, Dec 21, 2008 at 10:15:21AM -0200, Carlos A. M. dos Santos wrote:
> On Fri, Dec 19, 2008 at 6:20 PM, David E. O'Brien <obrien at freebsd.org> wrote:
> > Author: obrien
> > Date: Fri Dec 19 20:20:14 2008
> > New Revision: 186337
> > URL: http://svn.freebsd.org/changeset/base/186337
> >
> > Log:
> > burncd(8) doesn't handle signals and interrupting burncd during operation.
> > For example, ^C (SIGINT) may leave the drive spinning and locked.
> > This may also happen if you try to write a too-large image to a disc
> > and burncd(8) exits with an I/O error.
> >
> > Add signal handling by doing a CDRIOCFLUSH ioctl to attempt to leave
> > burner in a sane state when burning is interrupted with SIGHUP, SIGINT,
> > SIGTERM, or in case an I/O error occurs during write.
> > Note, that blanking will still continue after interrupt but it seems to
> > finish correctly even after burncd(8) has quit.
> >
> > Also, while I'm here bump WARNS to "6".
> >
> > PR: 48730
> > Submitted by: Jaakko Heinonen <jh at saunalahti.fi>
>
> While you are here, would you mind taking a look at bin/123693, either
> committing the proposed patch or closing the PR if my proposition is
> not acceptable?
Yep, I already have that patch to look at. Note it was hell getting the
patch - its best to not attach it when it will be base64 encoded - we
have no easy way of extracting such encoded attachements.
--
-- David (obrien at FreeBSD.org)
More information about the svn-src-all
mailing list