socsvn commit: r290244 - in soc2015/btw/head/sys: net netinet netinet6

Tiwei Bie btw at mail.ustc.edu.cn
Thu Aug 27 11:08:32 UTC 2015


On Thu, Aug 27, 2015 at 10:13:38AM +0000, Bjoern A. Zeeb wrote:
> 
> > On 27 Aug 2015, at 07:54 , btw at FreeBSD.org wrote:
> > 
> > Author: btw
> > Date: Thu Aug 27 07:54:00 2015
> > New Revision: 290244
> > URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=290244
> > 
> > Log:
> >  Replace the printf()s with optional rate limited debugging for RSS.
> > 
> > Modified:
> >  soc2015/btw/head/sys/net/rss_config.c
> >  soc2015/btw/head/sys/net/rss_config.h
> >  soc2015/btw/head/sys/netinet/in_rss.c
> >  soc2015/btw/head/sys/netinet6/in6_rss.c
> 
> 
> Ideally you’d add SDT probes for that as well;  printfs for debugging is something we should really stop avoiding I think.
> 

Got it! Thank you so much for your suggestions! :-) I also think it is a
good idea to use SDT probes. This patch is the draft of this review [1].
I will forward it to adrian@ and gnn at .

Best regards,
Tiwei Bie

[1] https://reviews.freebsd.org/D3471.



More information about the svn-soc-all mailing list