svn commit: r541296 - in head: databases/kexi devel/injeqt textproc/libkolabxml x11/sddm

[Gleb Popov]

On Mon, Jul 6, 2020 at 1:44 AM Tobias C. Berner <tcberner at freebsd.org>
wrote:

> Well, I disagree. I find it exactly the opposite :)
>

+1, CMAKE_ON gets parsed by my brain faster than  -DBUILD_MAN_PAGES=ON


>
> mfg Tobias
>
> On Sun, 5 Jul 2020 at 21:26, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> >
> > On Sun, Jul 05, 2020 at 07:20:21PM +0000, Tobias C. Berner wrote:
> > > New Revision: 541296
> > > URL: https://svnweb.freebsd.org/changeset/ports/541296
> > >
> > > Log:
> > >   Switch to using CMAKE_ON/CMAKE_OFF instead of more clunky CMAKE_ARGS
> > >
> > > Modified: head/x11/sddm/Makefile
> > > ...
> > > +CMAKE_ON=    BUILD_MAN_PAGES
> > >  CMAKE_ARGS=  -DUID_MIN=1000 \
> > >               -DUID_MAX=65000 \
> > >               -DCMAKE_INSTALL_SYSCONFDIR:PATH=${LOCALBASE}/etc \
> > > -             -DBUILD_MAN_PAGES=ON \
> > >
>  -DRST2MAN_EXECUTABLE=${LOCALBASE}/bin/rst2man.py-${PYTHON_VER}
> >
> > This one looks like pessimization.  Please be more considerate with these
> > changes; I, for one, do not like CMAKE_ON/OFF as I find it harder to read
> > and understand and prefer explicit assignments via CMAKE_ARGS.
> >
> > ./danfe
>