svn commit: r496814 - in head: net-im net-im/mtxclient net-im/mtxclient/files security security/olm

[Adriaan de Groot]

On Friday, 7 August 2020 15:03:22 CEST Alexey Dokuchaev wrote:
> On Mon, Mar 25, 2019 at 10:40:42AM +0000, Adriaan de Groot wrote:
> > New Revision: 496814
> > URL: https://svnweb.freebsd.org/changeset/ports/496814
> > 
> > Log:
> >   New ports security/olm and net-im/mtxclient
> >   
> >   These are support libraries for Matrix clients; Nheko in particular.
> >   Until I wrap-up Nheko, they aren't used by anything.
> > 
> > Added: head/net-im/mtxclient/Makefile
> > ...
> > +
> > +BUILD_DEPENDS=	nlohmann-json>=3:devel/nlohmann-json \
> > +		spdlog>=1.3:devel/spdlog \ \
> 
> Ouch, `devel/googletest' in BUILD_DEPENDS, that's gross! 

"that's gross" is not a particularly meaningful comment. I have no idea what 
you're getting at (especially not four months after-the-fact).

> Would you
> kindly consider dropping the hard dependency and adding CMAKE_ARGS=
> -DBUILD_LIB_TESTS:BOOL=OFF instead?

Sure. Generally I package things up with as little change from upstream as 
possible. By default mtxclient **does** build tests, and to do so has certain 
straightforward dependencies. I don't usually see a reason to reduce testing 
or validity checking during builds.

So .. whatevs? It's just a build dep, doesn't affect the installed package at 
all.

[ade]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20200813/64aa40db/attachment.sig>