svn commit: r512675 - head/www/gohugo

[Mathieu Arnold]

On Mon, Sep 23, 2019 at 08:42:02PM +0000, Dmitri Goutnik wrote:
> Author: dmgk
> Date: Mon Sep 23 20:42:02 2019
> New Revision: 512675
> URL: https://svnweb.freebsd.org/changeset/ports/512675
> 
> Log:
>   Include bsd.port.pre.mk to get DISTINFO_FILE in scope for the shell command.
>   
>   Reviewed by:	tobik
>   Approved by:	araujo (mentor)
>   Differential Revision:	https://reviews.freebsd.org/D21735
> 
> Modified:
>   head/www/gohugo/Makefile
> 
> Modified: head/www/gohugo/Makefile
> ==============================================================================
> --- head/www/gohugo/Makefile	Mon Sep 23 20:41:42 2019	(r512674)
> +++ head/www/gohugo/Makefile	Mon Sep 23 20:42:02 2019	(r512675)
> @@ -106,9 +106,6 @@ GO_BUILDFLAGS=	-ldflags="\
>  		-X github.com/gohugoio/hugo/hugolib.CommitHash=${COMMIT_ID}" \
>  		${BUILD_TAGS}
>  
> -SOURCE_DATE_EPOCH_CMD=	date -r $$(grep TIMESTAMP ${DISTINFO_FILE} | ${SED} -e 's/[^0-9]//g') '+%FT%TZ%z'
> -COMMIT_ID=	4aac02d49c2e2bab9f36f0caabbbd9f3cb4715cd
> -
>  OPTIONS_DEFINE=		MANPAGES EXTENDED
>  OPTIONS_DEFAULT=	MANPAGES EXTENDED
>  OPTIONS_SUB=		yes
> @@ -127,6 +124,12 @@ PORTMANS=	hugo-config.1 hugo-convert-toJSON.1 hugo-con
>  		hugo-new-site.1 hugo-new-theme.1 hugo-new.1 hugo-server.1 \
>  		hugo-version.1 hugo.1
>  
> +# needed to get DISTINFO_FILE in scope for the shell command evaluation by go.mk
> +.include <bsd.port.pre.mk>

No you don't.  make(1) does lazy evaluation, which means it will only
try to figure out the content of a variable when it is used.  When the
targets are run, all variables are available.  You do not need to
include bsd.port.pre.mk.

> +SOURCE_DATE_EPOCH_CMD=	date -r $$(grep TIMESTAMP ${DISTINFO_FILE} | ${SED} -e 's/[^0-9]//g') '+%FT%TZ%z'
> +COMMIT_ID=	4aac02d49c2e2bab9f36f0caabbbd9f3cb4715cd
> +
>  do-build-MANPAGES-on:
>  	@cd ${GO_WRKSRC} && ${GO_WRKDIR_BIN}/${PORTNAME} gen man --dir man/man1/
>  
> @@ -135,4 +138,4 @@ do-install-MANPAGES-on:
>  	${INSTALL_MAN} ${WRKSRC}/man/man1/$i ${STAGEDIR}/${PREFIX}/man/man1
>  .endfor
>  
> -.include <bsd.port.mk>
> +.include <bsd.port.post.mk>
> 

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190924/0edc3020/attachment.sig>