svn commit: r494945 - in head/comms/wsjtx: . files

[Alexey Dokuchaev]

On Thu, Mar 07, 2019 at 01:56:31PM +0000, Alexey Dokuchaev wrote:
> On Thu, Mar 07, 2019 at 01:45:04PM +0000, Diane Bruce wrote:
> > New Revision: 494945
> > URL: https://svnweb.freebsd.org/changeset/ports/494945
> > 
> > Log:
> >   - update to 2.0.1
> >   - builds on i386 now
> >   - remove MAKE_JOBS_UNSAFE
> 
> When removing MAKE_JOBS_UNSAFE, it is expected to explain what was wrong
> before and why it is believed to be fixed now, otherwise the error might
> have simply not manifested itself.

See the example of how it's supposed to be handled in r495588.

> >     this updated port. The cmake build provided does not have an
> >     install/strip target which forces use of do-install.
> > ...
> > +do-install:
> > +	(cd ${CONFIGURE_WRKSRC};${MAKE} -f Makefile DESTDIR=${STAGEDIR} install)
> 
> This do-install target is very bogus (CONFIGURE_WRKSRC? ${MAKE}? whitespace
> bugs), but more importantly, why not patch CMakeLists.txt to provide a nice
> installation routine instead of this ugliness?

Any comment on this part?  I see it's still not fixed after almost a week.

./danfe