svn commit: r505349 - in head/multimedia: mencoder mplayer mplayer/files

[Alexey Dokuchaev]

On Sat, Jun 29, 2019 at 10:50:41PM +0200, Thomas Zander wrote:
> On Sat, 29 Jun 2019 at 17:03, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> > The fact that you've dropped the RTC option is obvious from the commit
> > diff itself.  What's not obvious (and thus should be part of the commit
> > log) is the reasons behind this decision.
> 
> The advantages of supporting it have always been somewhat
> questionable. Personally, I have never encountered a single issue that
> could be solved by enabling RTC.
> Also most of our video-playing user base have not been able to use it
> for quite some time anyway, with nobody complaining:
> > grep BROKEN /usr/ports/emulators/rtc/Makefile
> BROKEN_FreeBSD_12=    fails to compile: rtc.c:166:2: implicit
> declaration of function 'MALLOC' is invalid in C99
> BROKEN_FreeBSD_13=    fails to compile: rtc.c:166:2: implicit
> declaration of function 'MALLOC' is invalid in C99

Thanks, I did not doubt that it was dropped for a reason.  However, it
should have been properly reflected (explained) in the commit log.

./danfe