svn commit: r504800 - in head/cad: . kicad-doc

[Christoph Moench-Tegeder]

## Alexey Dokuchaev (danfe at freebsd.org):

> Sorry, but I'm afraid it was badly reviewed.

We can fix that... and it's all on me.

> > +MAINTAINER=	cmt at FreeBSD.org
> > +COMMENT=	KiCad Online Documentation/Help Files
> 
> Comment is confusing ("online" typically means one does not have to
> install anything locally, that makes it "offline")...

Not that I'm attached to "online" - but I was thinking "online docs" ==
"whatever you get with the built-in help function", and "offline docs"
are printed (or something to that tune). That may indicate that I'm
somewhat old. Whatever.

> > +++ head/cad/kicad-doc/pkg-descr	Fri Jun 21 13:52:01 2019
> > @@ -0,0 +1,3 @@
> > +This port installs the official KiCad schematic symbol libraries.
> 
> ... and does not align well with the port description.

Argh, thanks for spotting. Lost edit. But there's not much to this
port to describe, it's just the help files - it just felt "more right"
to have them as their own ports, as this thing alone is around 230MB
package file and built from it's own repository.

> > +PLIST_SUB=	PORTDOCS=""
> 
> Why not simply remove %%PORTDOCS%% from the pkg-plist if you're setting
> it to an empty value unconditionally?

Because I was holding it wrong, in some non-reproducable way. I was
getting empty packages until I found this hack - but now that I've made
an ass of myself, everything works again.

> > +NO_ARCH=	yes
> 
> This knob should appear earlier.

Where? I can't find it anywhere in "Order of Variables" (Ch. 15 of
the Porter's Handbook), so I was putting it at the end, as in "The
Rest of the Variables") and portlint didn't complain. And looking
at other ports, the situation is... not clear.

Regards,
Christoph

-- 
Spare Space