svn commit: r503385 - head/Mk/Scripts

[Mathieu Arnold]

On Sat, Jun 15, 2019 at 05:01:58PM +0200, Tijl Coosemans wrote:
> On Mon, 3 Jun 2019 12:57:44 +0000 (UTC) Mathieu Arnold <mat at FreeBSD.org>
> wrote:
> > Author: mat
> > Date: Mon Jun  3 12:57:44 2019
> > New Revision: 503385
> > URL: https://svnweb.freebsd.org/changeset/ports/503385
> > 
> > Log:
> >   Use UCL for pkg-message
> >   
> >   Remain backward compatible but use ucl for the pkg-messages, which allows to:
> >   - append messages one after the other
> >   - only print message on delete, install, upgrade from a version to another
> >   
> >   If pkg-message starts with a [ we consider it should be a valid ucl file
> >   
> >   The format is the following:
> >   [
> >   { message: "Always print" },
> >   { message: "package being removed", type: remove },
> >   { message: "package being installed", type: install },
> >   { message: "package is being upgraded", type: upgrade },
> >   { message: "Upgrading from lower than 1.0", maximum_version: "1.0", type: upgrade },
> >   { message: "Upgrading from higher than 1.0", minimum_version: "1.0", type: upgrade  },
> >   { message: "Upgrading from >1.0 < 3.0", maximum_version: "3.0", minimum_version: "1.0",
> >   ]
> >   
> >   Because it is ucl one can use some sugar like:
> >   [
> >   { message = <<EOD
> >   formatted
> >   message 'with fancy things'
> >   EOD
> >   },
> >   }
> 
> Can this be extended to include these fields:
> opsys: <operating system this message applies to>
> osversion: <list of os version ranges this message applies to>
> arch: <list of architectures this message applies to>
> options: <list of options that need to be on or off>

I am not sure adding more fields is a good idea.
It should remain simple, otherwise there is a risk of the pkg-message
syntax getting bloated, and it is bound to be misused, especially as the
use case would be very rare.
It would probably be better to add files to _PKGMESSAGES when the case
you want to handle presents itself.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190618/1b7f7834/attachment.sig>