svn commit: r493407 - head/graphics/xpdf4

[Cy Schubert]

In message <20190220072105.GA8896 at urd.tobik.me>, Tobias Kortkamp writes:
> 
>
> --2fHTh5uZTiUOsy+g
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Tue, Feb 19, 2019 at 10:55:38PM -0800, Cy Schubert wrote:
> > In message <20190220063422.GA18880 at urd.tobik.me>, Tobias Kortkamp=20
> > writes:
> > >=20
> > >
> > > --OXfL5xGRrasGEqWY
> > > Content-Type: text/plain; charset=3Dus-ascii
> > > Content-Disposition: inline
> > > Content-Transfer-Encoding: quoted-printable
> > >
> > > On Wed, Feb 20, 2019 at 06:14:57AM +0000, Cy Schubert wrote:
> > > > Author: cy
> > > > Date: Wed Feb 20 06:14:57 2019
> > > > New Revision: 493407
> > > > URL: https://svnweb.freebsd.org/changeset/ports/493407
> > > >=3D20
> > > > Log:
> > > >   Remove whitespace in USE_QT, otherwise qmake_build is ignored.
> > > >  =3D20
> > > >   Reported by:	Paul Beard <paulbeard at gmail.com>
> > > >=3D20
> > > > Modified:
> > > >   head/graphics/xpdf4/Makefile
> > > >=3D20
> > > > Modified: head/graphics/xpdf4/Makefile
> > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3=
> D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
> > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=
> =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
> > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=
> =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
> > > =3D3D=3D3D=3D3D=3D3D
> > > > --- head/graphics/xpdf4/Makefile	Wed Feb 20 04:50:53 2019
> 	(r49340
> > > 6)
> > > > +++ head/graphics/xpdf4/Makefile	Wed Feb 20 06:14:57 2019
> 	(r49340
> > > 7)
> > > > @@ -27,8 +27,7 @@ SUB_FILES=3D3D	xpdf-man.conf
> > > > =3D20
> > > >  USES=3D3D		compiler:c++11-lang cmake localbase:ldflags \
> > > >  		desktop-file-utils qt:5
> > > > -USE_QT=3D3D		buildtools_build,concurrent,core,gui,network,pr
> intsuppo
> > > rt,\
> > > > -		qmake_build,svg,widgets
> > > > +USE_QT=3D3D		buildtools_build,concurrent,core,gui,network,pr
> intsuppo
> > > rt,qma=3D
> > > ke_build,svg,widgets
> > >
> > > Next step: Replace the , with spaces to actually add Qt dependencies
> > > to the port.  Check with build-depends-list, run-depends-list,
> > > stage-qa.  Currently the port has no Qt 5 dependencies and it fails
> > > to build in Poudriere:
> > >
> > > =3D3D=3D3D=3D3D> Checking for items in pkg-plist which are not in STAGE=
> DIR
> > > Error: Missing: libexec/xpdf/xpdf
> > > Error: Missing: %%DATADIR%%/man/man1/xpdf.1.gz
> > > =3D3D=3D3D=3D3D> Error: Plist issues found.
> >=20
> > This must have been wrong all along. I'm not sure how it would have=20
> > ever built before.
>
> Thanks for fixing it.  I can confirm that it builds fine now for
> me in Poudriere.

It builds fine by hand here however, I killed the FreeBSD 11 build on 
one of my machines downstairs to reboot back to -current to start a 
poudriere build. (My sandbox machines double as poudriere build 
servers). It fails to build on my poudriere. It's missing another 
dependency.

>
> But let me clarify.  It was not broken before, only after today.
> Previously the port used an options helper like
>
> GUI_USE=3D	QT=3Dx,y,z
>
> which was correct.  This translates (see [1]) to
>
> =2Eif ${PORT_OPTIONS:MGUI}
> USE_QT+=3D	x y z
> =2Eendif
>
> as it should be.  It however does *not* translate to
>
> =2Eif ${PORT_OPTIONS:MGUI}
> USE_QT+=3D	x,y,z
> =2Eendif
>
> So the refactoring from earlier (removing the GUI option) was not
> correct and the problem was only introduced today.
>
> [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/make=
> file-options.html#options-use

Gotcha. Thanks.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.