svn commit: r509282 - in head/Mk: . Scripts

[Mathieu Arnold]

Author: mat
Date: Mon Aug 19 12:18:21 2019
New Revision: 509282
URL: https://svnweb.freebsd.org/changeset/ports/509282

Log:
  Add a QA check warning porters about non UCL pkg-message files.
  
  Reviewed by:	adamw
  Differential Revision:	https://reviews.freebsd.org/D21262

Modified:
  head/Mk/Scripts/qa.sh   (contents, props changed)
  head/Mk/bsd.port.mk   (contents, props changed)

Modified: head/Mk/Scripts/qa.sh
==============================================================================
--- head/Mk/Scripts/qa.sh	Mon Aug 19 12:18:16 2019	(r509281)
+++ head/Mk/Scripts/qa.sh	Mon Aug 19 12:18:21 2019	(r509282)
@@ -994,10 +994,24 @@ depends_blacklist()
 	return $rc
 }
 
+pkgmessage()
+{
+	for message in ${PKGMESSAGES}; do
+		if [ -f "${message}" ]; then
+			if ! head -1 "${message}" | grep -q '^\['; then
+				warn "${message} not in UCL format, will be shown on initial install only."
+				warn "See https://www.freebsd.org/doc/en/books/porters-handbook/pkg-files.html#porting-message"
+			fi
+		fi
+	done
+
+	return 0
+}
+
 checks="shebang symlinks paths stripped desktopfileutils sharedmimeinfo"
 checks="$checks suidfiles libtool libperl prefixvar baselibs terminfo"
 checks="$checks proxydeps sonames perlcore no_arch gemdeps gemfiledeps flavors"
-checks="$checks license depends_blacklist"
+checks="$checks license depends_blacklist pkgmessage"
 
 ret=0
 cd ${STAGEDIR} || exit 1

Modified: head/Mk/bsd.port.mk
==============================================================================
--- head/Mk/bsd.port.mk	Mon Aug 19 12:18:16 2019	(r509281)
+++ head/Mk/bsd.port.mk	Mon Aug 19 12:18:21 2019	(r509282)
@@ -1601,6 +1601,7 @@ QA_ENV+=		STAGEDIR=${STAGEDIR} \
 				"STRIP=${STRIP}" \
 				TMPPLIST=${TMPPLIST} \
 				CURDIR='${.CURDIR}' \
+				PKGMESSAGES='${_PKGMESSAGES}' \
 				FLAVOR=${FLAVOR} \
 				FLAVORS='${FLAVORS}' \
 				BUNDLE_LIBS=${BUNDLE_LIBS} \