svn commit: r508723 - head/net/ocserv

[Cy Schubert]

On August 12, 2019 10:21:02 AM PDT, Carlos Jacobo Puga Medina <cjpm at gmx.es> wrote:
>
>
>--
>Carlos Jacobo Puga Medina <cjpm at gmx.es>
>
>
>> Enviar: lunes 12 de agosto de 2019 a las 15:52
>> De: "Alexey Dokuchaev" <danfe at freebsd.org>
>> Para: "Carlos J. Puga Medina" <cpm at freebsd.org>
>> CC: ports-committers at freebsd.org, svn-ports-all at freebsd.org,
>svn-ports-head at freebsd.org
>> Asunto: Re: svn commit: r508723 - head/net/ocserv
>>
>> On Mon, Aug 12, 2019 at 10:52:00AM +0000, Carlos J. Puga Medina
>wrote:
>> > New Revision: 508723
>> > URL: https://svnweb.freebsd.org/changeset/ports/508723
>> >
>> > Log:
>> >   net/ocserv: Fix typos in pkg-descr
>> >
>> >   PR:		239577
>> >   Submitted by:	Mikael Urankar <mikael.urankar at gmail.com>
>> >
>> > Modified: head/net/ocserv/pkg-descr
>> >
>==============================================================================
>> > --- head/net/ocserv/pkg-descr	Mon Aug 12 10:39:48 2019	(r508722)
>> > +++ head/net/ocserv/pkg-descr	Mon Aug 12 10:52:00 2019	(r508723)
>> > @@ -6,9 +6,9 @@ The OpenConnect protocol provides a dual TCP/UDP
>VPN c
>> >  uses the standard IETF security protocols to secure it. Both IPv4
>> >  and IPv6 are supported.
>> >
>> > -Ocserv's main features are security through provilege separation
>> > +Ocserv's main features are security through privilege separation
>> >  and sandboxing, accounting, and resilience due to a combined use
>> > -of TCP and UDP.  Authentication occurs in an isolated security
>> > +of TCP and UDP. Authentication occurs in an isolated security
>>
>> This was not a typo, plain text generally looks better with double
>> spaces after full stop; it might not be as popular in other places/
>> traditions as it is in US, but FreeBSD typically adheres to Americal
>> spelling and formatting rules.
>>
>> Regardless of one's personal preference, touching the line merely to
>> change the amount of whitespace between sentences is gratuitous (part
>> of the) commmit and should've been avoided.
>>
>
>Thanks for the explanation. In fact, if you strongly disagree, please
>do not hesitate to revert the commit.
>
>> ./danfe
>>
>>

Personally,  I prefer to keep style and formatting changes separate from functional changes. This is especially relevant for base but IMO also relevant for ports. Months or years from now when bisecting a revision, it is easier to review only a functional change than to have to work through a change polluted by gratuitous formatting changes. Consider the poor soul who's trying to figure out what was done long after a commit. Either don't reformat or reformat in a separate commit. Pet portlint separately too. It also makes bisecting more time consuming.


-- 
Pardon the typos and autocorrect, small keyboard in use.
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX: <cy at FreeBSD.org> Web: http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.