svn commit: r469188 - head/ports-mgmt/pkg_replace

[Alexey Dokuchaev]

On Sun, May 06, 2018 at 01:17:14PM +0000, Koichiro Iwao wrote:
> On Sun, May 06, 2018 at 10:50:12AM +0000, Alexey Dokuchaev wrote:
> > *facepalm*.  This poudriere-driven development is more and more disturbing.
> > You didn't attempt to understand the problem, you didn't attempt to fix the
> > PLIST_FILES (remove bogus %%ETCDIR%% since this is Makefile), you didn't
> > ask for a peer review.  meta@ pessimized the port, provided wrong commit
> > log (it tells *nothing* about poudriere failing with a signal 6 in make
> > package, it says "pet portlint"), and you've approved it like there's
> > nothing wrong with all of this. :-(
> 
> Sorry about that. I understand what I should have done and I could do.

Oh I don't blame you at all.  Your mentor is currently earning all the
pointy hats. :-)

> Then what should I do next?  Should I turn back to PLIST_FILES?

That would be what we call "gratuitous change" here.  The deed was done,
if it works, leave it.  You might want to revisit it later alongside with
other changes.

> What should I do from the next time not to repeat such a folly?

Study PHB and other people's work (I understand that not everyone has time
or desire to read through all svn-ports-* emails, but being a new committer
it could be helpful for you at least in the beginning).  Study other ports,
often they can offer nice a idea (bad ones as well, more often).  Question
your decisions, question others' decisions, when it doubt, ask for a peer
review.  There are quite a few highly qualified and experienced committers.

./danfe