[toolchain] svn commit: r474650 - in head/lang: . gcc8 [ not added to bsd.gcc.mk nor to the comment in bsd.default-versions.mk ]

[John Baldwin]

On 7/28/18 8:05 AM, Gerald Pfeifer wrote:
> On Sun, 15 Jul 2018, Gerald Pfeifer wrote:
>>> https://svnweb.freebsd.org/ports/head/Mk/bsd.default-versions.mk :
>>>
>>> # Possible values: 4.9, 5, 6, 7
>>> GCC_DEFAULT?=           6
>> Given that this is still the first release of the GCC 8 series, 
>> I'm a bit hesitant to add it there.  Too many folks too eager 
>> running into problems and then not knowing how to go about it.
>>
>> I'd rather wait for GCC 8.2 which is due this summer.
> 
> With GCC 8.2 out now (and hence also the fix of an minor C++ 
> ABI bug introduced with GCC 8.1) I have now made this change 
> to Mk/bsd.default-versions.mk.
> 
> 
> If anyone can help me with the finishing touches of changed the
> default to GCC 7 and start working on GCC 8, that would be great
> and much appreciated!

One random thing to consider that is GCC related.  For FreeBSD 12.0
and later we are planning to use init_array and fini_array instead of
ctors/dtors for lists of constructor and destructor functions.  clang
in head has already been changed to do this, and I've patched the
external toolchain versions of GCC in devel/*-gcc and base/gcc to do
this.  lang/gcc* should also probably be patched with a similar patch
to what I used in base/gcc to enable it based on OSVERSION:

--- head/base/gcc/Makefile	2018/06/08 16:06:49	472012
+++ head/base/gcc/Makefile	2018/07/11 16:50:00	474469
@@ -2,6 +2,7 @@
 
 PORTNAME=	gcc
 PORTVERSION=	6.4.0
+PORTREVISION=	1
 CATEGORIES=	base
 MASTER_SITES=	GCC/releases/gcc-${DISTVERSION} \
 		http://www.mpfr.org/mpfr-3.1.6/:mpfr \
@@ -61,6 +62,10 @@ INSTALL_TARGET?=	install-gcc
 
 .include <bsd.port.pre.mk>
 
+.if ${OSVERSION} >= 1200000
+CONFIGURE_ARGS+= --enable-initfini-array
+.endif
+
 .if ${ARCH:Mmips*}
 PLIST_SUB+=	MIPS=""
 .else

-- 
John Baldwin