svn commit: r459751 - in head/lang: . solidity solidity/files

[Alexey Dokuchaev]

On Tue, Jan 23, 2018 at 03:31:03PM +0100, Alex Dupre wrote:
> Alexey Dokuchaev wrote:
> >> +COMMENT=	Solidity Contract-Oriented Programming Language
> > 
> > COMMENT=	Contract-oriented programming language
> 
> Come on, then the comment for the scala port should be "Programming
> Language"?

`lang/scala's COMMENT is also quite bad.  It is not an excuse to add
more bad and excessively-cap'ed COMMENTs.

> >> +OPTIONS_DEFINE=	SMT
> >> +SMT_DESC=	SMT Checker
> >> +SMT_LIB_DEPENDS=libz3.so:math/z3
> >> +
> >> +USES=		cmake
> > 
> > Misplaced USES.
> 
> I don't see what's misplaced here, portlint doesn't seem to agree with you.

OPTIONS blocks should come last, right before the targets.

> >> +CMAKE_ARGS+=	-DUSE_LD_GOLD=OFF -DTESTS=OFF \
> >> +		-DJSONCPP_INCLUDE_DIR:STRING="${LOCALBASE}/include/jsoncpp" \
> >> +		-DJSONCPP_LIB_DIR:STRING="${LOCALBASE}/lib"
> > 
> > And CMAKE_ARGS (also bogus +=).
> 
> Really?

Yes: I don't see the reason for amending CMAKE_ARGS here; it's not a slave
port or something.  Straight assignment is both appropriate and does not
raise questions (e.g. "why CMAKE_ARGS has to be added to here, am I missing
something"?).

> >> +pre-patch:
> >> +		@${CP} ${FILESDIR}/jsoncpp.cmake ${WRKSRC}/cmake/
> >> +		@${REINPLACE_CMD} '/EthCcache/d' ${WRKSRC}/CMakeLists.txt
> > 
> > Excessive indentation of target recipe (commands).
> 
> Seriously?

Of course.  Target recipes are indented with single tab in most of the
ports, why would you want to break the consistency?

./danfe