svn commit: r459753 - in head/deskutils: . freeplane freeplane/files

[Mathieu Arnold]

On Tue, Jan 23, 2018 at 04:12:52PM +0100, Tobias Kortkamp wrote:
> On Tue, Jan 23, 2018, at 15:19, Alexey Dokuchaev wrote:
> > On Tue, Jan 23, 2018 at 02:15:56PM +0000, Tobias Kortkamp wrote:
> > > New Revision: 459753
> > > URL: https://svnweb.freebsd.org/changeset/ports/459753
> > > 
> > > Log:
> > >   New port: deskutils/freeplane
> > >   
> > > Added: head/deskutils/freeplane/Makefile
> > > ...
> > > @@ -0,0 +1,35 @@
> > > +# Created by: Lo??c Bartoletti <lbartoletti at tuxfamily.org>
> > > +# $FreeBSD$
> > 
> > ASCII please.
> > 
> > > +# Install freeplane.sh with the right permission, link to it to bin/
> > > +# and let it resolve the path to DATADIR automatically to avoid
> > > +# patching it further.  For this to work it has to be a link to an
> > > +# absolute path.
> > > +	${INSTALL_SCRIPT} ${WRKSRC}/freeplane.sh ${STAGEDIR}${DATADIR}
> > > +	${LN} -s ${DATADIR}/freeplane.sh ${STAGEDIR}${PREFIX}/bin/freeplane
> > 
> > Symlinks pointing to an absolute path are bad.
> > 
> > ./danfe
> 
> Can you please explain why they "are bad"?

They are bad when they reference LOCALBASE or PREFIX.

https://www.freebsd.org/doc/en/books/porters-handbook/special.html#staging-symlink

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20180123/81f6970f/attachment.sig>