svn commit: r477695 - in head/graphics: . libheif

[Kurt Jaeger]

Hi!

> On 8/20/18 5:24 PM, Kurt Jaeger wrote:
> > +BROKEN_FreeBSD_10=	encoder_fuzzer.cc:84:5: error: use of undeclared identifier 'free'
> 
> This is most likely wrong. 'free' is available everywhere. The likely 
> reason is a missing #include <stdlib.h> somewhere.

Yes, it was wrong. Thanks for the pointer, fixed.

> > +LIB_DEPENDS=		libde265.so:multimedia/libde265
> > +LIB_DEPENDS+=		libx265.so:multimedia/x265
> > +LIB_DEPENDS+=		libpng16.so:graphics/png

> These are usually defined without repeating LIB_DEPENDS+=.

Fixed.

> > +USES=			autoreconf libtool pkgconfig shared-mime-info \
> > +			shebangfix
> > +USE_GITHUB=		yes
> > +GH_ACCOUNT=		strukturag
> > +GH_PROJECT=		libheif
> > +
> > +GNU_CONFIGURE=		yes
> > +
> > +SHEBANG_GLOB=		*.sh
> > +
> > +USE_LDCONFIG=		yes
> 
> USE_LDCONFIG should definitely be in the USExx section. GNU_CONFIGURE and SHEBANG_GLOB should also probably be in USExx section, because this way Makefile looks more compact.

Done as you described.

-- 
pi at FreeBSD.org         +49 171 3101372              2 years to go !