svn commit: r449798 - head/net-mgmt/collectd5

[Dag-Erling Smørgrav]

Steve Wills <swills at FreeBSD.org> writes:
> I'm happy to see more options enabled by default in this port, thanks
> for that. We do have a policy that packaged binaries should be
> stripped. Enabling the DEBUG option by default would seem to be at
> odds with that policy to me. Could you please turn that one off by
> default?

# file /usr/local/sbin/collectd
/usr/local/sbin/collectd: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 11.0 (1100122), FreeBSD-style, stripped

The DEBUG option enables log messages which are indispensable when
troubleshooting a collectd installation (or rather, makes an additional
log level available).  I didn't realize that it also disables stripping.
If that is the case, it needs to be split in two, or maybe the relevant
configure argument should simply be hardcoded.

DES
-- 
Dag-Erling Smørgrav - des at des.no