svn commit: r453059 - in head: mail/thunderbird mail/thunderbird/files www/firefox www/firefox-esr www/firefox-esr/files www/firefox/files www/seamonkey www/seamonkey/files
Jan Beich
jbeich at FreeBSD.org
Sat Oct 28 15:42:23 UTC 2017
Author: jbeich
Date: Sat Oct 28 15:42:21 2017
New Revision: 453059
URL: https://svnweb.freebsd.org/changeset/ports/453059
Log:
gecko: double-click on tab bar crashfix for some WMs
Obtained from: upstream (Firefox 58)
PR: 222693
Submitted by: tobik
MFH: 2017Q4
Added:
head/mail/thunderbird/files/patch-bug1186967 (contents, props changed)
head/www/firefox-esr/files/patch-bug1186967 (contents, props changed)
head/www/firefox/files/patch-bug1186967 (contents, props changed)
head/www/seamonkey/files/patch-bug1186967 (contents, props changed)
Modified:
head/mail/thunderbird/Makefile (contents, props changed)
head/www/firefox-esr/Makefile (contents, props changed)
head/www/firefox/Makefile (contents, props changed)
head/www/seamonkey/Makefile (contents, props changed)
Modified: head/mail/thunderbird/Makefile
==============================================================================
--- head/mail/thunderbird/Makefile Sat Oct 28 15:09:38 2017 (r453058)
+++ head/mail/thunderbird/Makefile Sat Oct 28 15:42:21 2017 (r453059)
@@ -3,7 +3,7 @@
PORTNAME= thunderbird
DISTVERSION= 52.4.0
-PORTREVISION= 1
+PORTREVISION= 2
CATEGORIES= mail news net-im ipv6
MASTER_SITES= MOZILLA/${PORTNAME}/releases/${DISTVERSION}/source \
MOZILLA/${PORTNAME}/candidates/${DISTVERSION}-candidates/build3/source
Added: head/mail/thunderbird/files/patch-bug1186967
==============================================================================
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/mail/thunderbird/files/patch-bug1186967 Sat Oct 28 15:42:21 2017 (r453059)
@@ -0,0 +1,41 @@
+commit 64bb4e051b50
+Author: Martin Stransky <stransky at redhat.com>
+Date: Tue Oct 17 09:50:18 2017 +0200
+
+ Bug 1186967 - ignore double-click on WM without _NET_WM_MOVERESIZE support, r=jhorak
+
+ MozReview-Commit-ID: 2Vs6i5leero
+
+ --HG--
+ extra : rebase_source : d8f2bbaf9ef9b2025478f029a68ee7e87e07de79
+---
+ widget/gtk/nsWindow.cpp | 16 ++++++++++++++++
+ 1 file changed, 16 insertions(+)
+
+diff --git widget/gtk/nsWindow.cpp widget/gtk/nsWindow.cpp
+index eb2f0e5e95cd..955327297ac9 100644
+--- mozilla/widget/gtk/nsWindow.cpp
++++ mozilla/widget/gtk/nsWindow.cpp
+@@ -6444,6 +6444,22 @@ nsWindow::GetDragInfo(WidgetMouseEvent* aMouseEvent,
+ return false;
+ }
+
++ if (mIsX11Display) {
++ // Workaround for https://bugzilla.gnome.org/show_bug.cgi?id=789054
++ // To avoid crashes disable double-click on WM without _NET_WM_MOVERESIZE.
++ // See _should_perform_ewmh_drag() at gdkwindow-x11.c
++ GdkScreen* screen = gdk_window_get_screen(gdk_window);
++ GdkAtom atom = gdk_atom_intern("_NET_WM_MOVERESIZE", FALSE);
++ if (!gdk_x11_screen_supports_net_wm_hint(screen, atom)) {
++ static unsigned int lastTimeStamp = 0;
++ if (lastTimeStamp != aMouseEvent->mTime) {
++ lastTimeStamp = aMouseEvent->mTime;
++ } else {
++ return false;
++ }
++ }
++ }
++
+ // FIXME: It would be nice to have the widget position at the time
+ // of the event, but it's relatively unlikely that the widget has
+ // moved since the mousedown. (On the other hand, it's quite likely
Modified: head/www/firefox-esr/Makefile
==============================================================================
--- head/www/firefox-esr/Makefile Sat Oct 28 15:09:38 2017 (r453058)
+++ head/www/firefox-esr/Makefile Sat Oct 28 15:42:21 2017 (r453059)
@@ -4,7 +4,7 @@
PORTNAME= firefox
DISTVERSION= 52.4.1
DISTVERSIONSUFFIX=esr.source
-PORTREVISION= 1
+PORTREVISION= 2
PORTEPOCH= 1
CATEGORIES= www ipv6
MASTER_SITES= MOZILLA/${PORTNAME}/releases/${DISTVERSION}esr/source \
Added: head/www/firefox-esr/files/patch-bug1186967
==============================================================================
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/www/firefox-esr/files/patch-bug1186967 Sat Oct 28 15:42:21 2017 (r453059)
@@ -0,0 +1,41 @@
+commit 64bb4e051b50
+Author: Martin Stransky <stransky at redhat.com>
+Date: Tue Oct 17 09:50:18 2017 +0200
+
+ Bug 1186967 - ignore double-click on WM without _NET_WM_MOVERESIZE support, r=jhorak
+
+ MozReview-Commit-ID: 2Vs6i5leero
+
+ --HG--
+ extra : rebase_source : d8f2bbaf9ef9b2025478f029a68ee7e87e07de79
+---
+ widget/gtk/nsWindow.cpp | 16 ++++++++++++++++
+ 1 file changed, 16 insertions(+)
+
+diff --git widget/gtk/nsWindow.cpp widget/gtk/nsWindow.cpp
+index eb2f0e5e95cd..955327297ac9 100644
+--- widget/gtk/nsWindow.cpp
++++ widget/gtk/nsWindow.cpp
+@@ -6444,6 +6444,22 @@ nsWindow::GetDragInfo(WidgetMouseEvent* aMouseEvent,
+ return false;
+ }
+
++ if (mIsX11Display) {
++ // Workaround for https://bugzilla.gnome.org/show_bug.cgi?id=789054
++ // To avoid crashes disable double-click on WM without _NET_WM_MOVERESIZE.
++ // See _should_perform_ewmh_drag() at gdkwindow-x11.c
++ GdkScreen* screen = gdk_window_get_screen(gdk_window);
++ GdkAtom atom = gdk_atom_intern("_NET_WM_MOVERESIZE", FALSE);
++ if (!gdk_x11_screen_supports_net_wm_hint(screen, atom)) {
++ static unsigned int lastTimeStamp = 0;
++ if (lastTimeStamp != aMouseEvent->mTime) {
++ lastTimeStamp = aMouseEvent->mTime;
++ } else {
++ return false;
++ }
++ }
++ }
++
+ // FIXME: It would be nice to have the widget position at the time
+ // of the event, but it's relatively unlikely that the widget has
+ // moved since the mousedown. (On the other hand, it's quite likely
Modified: head/www/firefox/Makefile
==============================================================================
--- head/www/firefox/Makefile Sat Oct 28 15:09:38 2017 (r453058)
+++ head/www/firefox/Makefile Sat Oct 28 15:42:21 2017 (r453059)
@@ -4,7 +4,7 @@
PORTNAME= firefox
DISTVERSION= 56.0.2
DISTVERSIONSUFFIX=.source
-PORTREVISION= 3
+PORTREVISION= 4
PORTEPOCH= 1
CATEGORIES= www ipv6
MASTER_SITES= MOZILLA/${PORTNAME}/releases/${DISTVERSION}/source \
Added: head/www/firefox/files/patch-bug1186967
==============================================================================
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/www/firefox/files/patch-bug1186967 Sat Oct 28 15:42:21 2017 (r453059)
@@ -0,0 +1,41 @@
+commit 64bb4e051b50
+Author: Martin Stransky <stransky at redhat.com>
+Date: Tue Oct 17 09:50:18 2017 +0200
+
+ Bug 1186967 - ignore double-click on WM without _NET_WM_MOVERESIZE support, r=jhorak
+
+ MozReview-Commit-ID: 2Vs6i5leero
+
+ --HG--
+ extra : rebase_source : d8f2bbaf9ef9b2025478f029a68ee7e87e07de79
+---
+ widget/gtk/nsWindow.cpp | 16 ++++++++++++++++
+ 1 file changed, 16 insertions(+)
+
+diff --git widget/gtk/nsWindow.cpp widget/gtk/nsWindow.cpp
+index eb2f0e5e95cd..955327297ac9 100644
+--- widget/gtk/nsWindow.cpp
++++ widget/gtk/nsWindow.cpp
+@@ -6444,6 +6444,22 @@ nsWindow::GetDragInfo(WidgetMouseEvent* aMouseEvent,
+ return false;
+ }
+
++ if (mIsX11Display) {
++ // Workaround for https://bugzilla.gnome.org/show_bug.cgi?id=789054
++ // To avoid crashes disable double-click on WM without _NET_WM_MOVERESIZE.
++ // See _should_perform_ewmh_drag() at gdkwindow-x11.c
++ GdkScreen* screen = gdk_window_get_screen(gdk_window);
++ GdkAtom atom = gdk_atom_intern("_NET_WM_MOVERESIZE", FALSE);
++ if (!gdk_x11_screen_supports_net_wm_hint(screen, atom)) {
++ static unsigned int lastTimeStamp = 0;
++ if (lastTimeStamp != aMouseEvent->mTime) {
++ lastTimeStamp = aMouseEvent->mTime;
++ } else {
++ return false;
++ }
++ }
++ }
++
+ // FIXME: It would be nice to have the widget position at the time
+ // of the event, but it's relatively unlikely that the widget has
+ // moved since the mousedown. (On the other hand, it's quite likely
Modified: head/www/seamonkey/Makefile
==============================================================================
--- head/www/seamonkey/Makefile Sat Oct 28 15:09:38 2017 (r453058)
+++ head/www/seamonkey/Makefile Sat Oct 28 15:42:21 2017 (r453059)
@@ -3,7 +3,7 @@
PORTNAME= seamonkey
DISTVERSION= 2.49.1
-PORTREVISION= 1
+PORTREVISION= 2
MOZILLA_VER= 52 # above + 3
CATEGORIES?= www mail news editors irc ipv6
MASTER_SITES= MOZILLA/${PORTNAME}/releases/${DISTVERSION}/source \
Added: head/www/seamonkey/files/patch-bug1186967
==============================================================================
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/www/seamonkey/files/patch-bug1186967 Sat Oct 28 15:42:21 2017 (r453059)
@@ -0,0 +1,41 @@
+commit 64bb4e051b50
+Author: Martin Stransky <stransky at redhat.com>
+Date: Tue Oct 17 09:50:18 2017 +0200
+
+ Bug 1186967 - ignore double-click on WM without _NET_WM_MOVERESIZE support, r=jhorak
+
+ MozReview-Commit-ID: 2Vs6i5leero
+
+ --HG--
+ extra : rebase_source : d8f2bbaf9ef9b2025478f029a68ee7e87e07de79
+---
+ widget/gtk/nsWindow.cpp | 16 ++++++++++++++++
+ 1 file changed, 16 insertions(+)
+
+diff --git widget/gtk/nsWindow.cpp widget/gtk/nsWindow.cpp
+index eb2f0e5e95cd..955327297ac9 100644
+--- mozilla/widget/gtk/nsWindow.cpp
++++ mozilla/widget/gtk/nsWindow.cpp
+@@ -6444,6 +6444,22 @@ nsWindow::GetDragInfo(WidgetMouseEvent* aMouseEvent,
+ return false;
+ }
+
++ if (mIsX11Display) {
++ // Workaround for https://bugzilla.gnome.org/show_bug.cgi?id=789054
++ // To avoid crashes disable double-click on WM without _NET_WM_MOVERESIZE.
++ // See _should_perform_ewmh_drag() at gdkwindow-x11.c
++ GdkScreen* screen = gdk_window_get_screen(gdk_window);
++ GdkAtom atom = gdk_atom_intern("_NET_WM_MOVERESIZE", FALSE);
++ if (!gdk_x11_screen_supports_net_wm_hint(screen, atom)) {
++ static unsigned int lastTimeStamp = 0;
++ if (lastTimeStamp != aMouseEvent->mTime) {
++ lastTimeStamp = aMouseEvent->mTime;
++ } else {
++ return false;
++ }
++ }
++ }
++
+ // FIXME: It would be nice to have the widget position at the time
+ // of the event, but it's relatively unlikely that the widget has
+ // moved since the mousedown. (On the other hand, it's quite likely
More information about the svn-ports-head
mailing list