svn commit: r431187 - in head/devel/dbus: . files

[Baptiste Daroussin]

On Sun, Jan 15, 2017 at 02:14:55PM +0100, Tijl Coosemans wrote:
> On Sat, 14 Jan 2017 23:58:16 +0100 Baptiste Daroussin <bapt at FreeBSD.org> wrote:
> > On Wed, Jan 11, 2017 at 03:07:54PM +0000, Tijl Coosemans wrote:
> >> - at dir /var/db/dbus
> >> + at dir /var/lib/dbus
> >> + at dir /var/lib
> >>  @dir /var/run/dbus
> >> + at comment The following line may be removed after 2018-01-01
> >> + at postexec [ -f /var/lib/dbus/machine-id -o ! -f /var/db/dbus/machine-id ] || cp -p /var/db/dbus/machine-id /var/lib/dbus/
> > 
> > :(
> > 
> > I would have prefered a symlink rather this but hey (on FreeBSD /var/db
> > is the right place in theory :))
> 
> I'm really tired of FreeBSD putting files in different locations.  It's
> just more work and no benefit.  Pain without gain.  The right place is
> whatever gives us, maintainers and users, the least amount of work.  This
> is a balancing exercise between maintainers that need to maintain the
> hacks and patches and users that want to find certain files easily.  So
> for documentation I'm all for moving that to a consistent location, but
> for runtime files /var/lib instead of /var/db is fine.
> 
> For the same reason I also still think we should move libdata/pkgconfig
> to lib/pkgconfig.  The pile of hacks and patches that could be removed
> from the ports tree is truly immense and no user would ever realise it
> or care about it.
> 
> Just take a look at this oneliner, think about the work it could save us
> in the coming years and then please just commit it without hesitation :)

I'm not portmgr anymore so I'm not the one to decide on that. While I tend to
agree with the pkgconfig thing you are proposing, I really dislike /var/lib (but
I won't fight against it.) about /var/lib there are not that many patches mostly
a configure time option. but yes the issue there is mainly for compat with linux
binaries like the change you did.

Such proposal should be validated imho with by portmgr imho.


> 
> Index: devel/pkgconf/Makefile
> ===================================================================
> --- devel/pkgconf/Makefile	(revision 431371)
> +++ devel/pkgconf/Makefile	(working copy)
> @@ -2,6 +2,7 @@
>  
>  PORTNAME=	pkgconf
>  PORTVERSION=	1.1.1
> +PORTREVISION=	1
>  CATEGORIES=	devel
>  MASTER_SITES=	https://distfiles.dereferenced.org/pkgconf/ \
>  		http://files.etoilebsd.net/pkgconf/
> @@ -16,7 +17,7 @@ GNU_CONFIGURE=	yes
>  INSTALL_TARGET=	install-strip
>  USE_LDCONFIG=	yes
>  TEST_TARGET=	check
> -CONFIGURE_ARGS=	--with-pkg-config-dir=${PREFIX}/libdata/pkgconfig:/usr/libdata/pkgconfig \
> +CONFIGURE_ARGS=	--with-pkg-config-dir=${PREFIX}/lib/pkgconfig:${PREFIX}/libdata/pkgconfig:/usr/libdata/pkgconfig \
>  		--with-system-libdir=/usr/lib \
>  		--with-system-includedir=/usr/include
>  MAKE_ARGS=	MANDIR="${MAN1PREFIX}/man/man1"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20170115/9640327b/attachment.sig>