svn commit: r410612 - head/devel/libc++

[John Marino (NetBSD)]

On 2016-03-09 06:00, Bryan Drewery wrote:
> This is a synth bug and should be reverted.

Right now make -V LIB_DEPENDS shows accurately under every platform 
where it did not before.  Who would wish to revert it?  Or in other 
words, who thinks the previous version of libc++ is "more correct" than 
the current version?

> LIB_DEPENDS is already conditional on the specified library being
> missing.  The tool should only add the dependency if the library is not
> present because that is the behavior of LIB_DEPENDS (and *_DEPENDS) in
> ports without tools, meaning it is the intended behavior.  This was
> broken in portupgrade until r387621

I was 90% sure LIB_DEPENDS was designed to do what it was doing, but 
frankly I think it's technically a terrible design decision.  Now that 
you have two build tools that were negatively affected by it, that 
opinion has merit.

In other words, if anything, I'd like to formally re-evaluate that 
decision that have LIB_DEPENDS not being trustworthy as being ok with 
the goal of getting concurrence that it must be trustworthy.  e.g. 
LIB_DEPENDS most propagate to the built package and if it doesn't it's 
wrong.

1) There cannot be many ports left in the tree that were doing what 
libc++ was doing.  e.g. < 5 ?

2) it's easy to set LIB_DEPENDS conditionally

3) the current way is a POLA violation (IMO) and causes problems with 
package validity checks.  It is an unwanted side effect and it's easily 
fixed.  It requires people to understand technicallhy what package is 
doing?

Can we do the right thing here?

John