svn commit: r379501 - head/lang/v8

[John Marino]

On 2/21/2015 12:31, Sunpoet Po-Chuan Hsieh wrote:
> Author: sunpoet
> Date: Sat Feb 21 11:31:58 2015
> New Revision: 379501
> URL: https://svnweb.freebsd.org/changeset/ports/379501
> QAT: https://qat.redports.org/buildarchive/r379501/
> 
> Log:
>   - Fix build with Clang 3.6.0
>   - Use CXXFLAGS instead of CFLAGS
>   - Simplify CXXFLAGS: all supported Clang are 3.3+
> 
> Modified:
>   head/lang/v8/Makefile
> 
> Modified: head/lang/v8/Makefile
> ==============================================================================
> --- head/lang/v8/Makefile	Sat Feb 21 11:31:53 2015	(r379500)
> +++ head/lang/v8/Makefile	Sat Feb 21 11:31:58 2015	(r379501)
> @@ -32,14 +32,14 @@ python_CMD=	${PYTHON_CMD}
>  .include <bsd.port.pre.mk>
>  
>  .if ${COMPILER_TYPE} == clang
> -CFLAGS+=	-Wno-unused-private-field
> +CXXFLAGS+=	-Wno-nested-anon-types -Wno-unused-function -Wno-unused-private-field
>  MAKE_ENV+=	LINK=clang++
> -.if ${COMPILER_VERSION} >= 33
> -CFLAGS+=	-Wno-nested-anon-types -Wno-unused-function
>  .if ${COMPILER_VERSION} >= 34
> -CFLAGS+=	-Wno-unused-const-variable
> +CXXFLAGS+=	-Wno-unused-const-variable
>  .if ${COMPILER_VERSION} >= 35
> -CFLAGS+=	-Wno-tautological-undefined-compare
> +CXXFLAGS+=	-Wno-tautological-undefined-compare
> +.if ${COMPILER_VERSION} >= 36
> +CXXFLAGS+=	-Wno-unused-local-typedef
>  .endif
>  .endif
>  .endif
> 

Upstream has finally given up and disabled Werror:
https://github.com/joyent/node/commit/f057c7049eea6e6396dfd8117910ccb2a5c8977a

GCC5 needs these fixes too, but you have this limited to clang
(understandably).  V8 really needs this patch from upstream instead
unless v8 is being updated to a newer version imminently.

Shouldn't that patch be used instead?
John