svn commit: r385072 - head/x11/lumina

[Kris Moore]

On 04/30/2015 18:56, Baptiste Daroussin wrote:
> On Thu, Apr 30, 2015 at 06:53:59PM -0400, Kris Moore wrote:
>> On 04/30/2015 18:50, Baptiste Daroussin wrote:
>>> On Fri, May 01, 2015 at 12:47:37AM +0200, Jan Beich wrote:
>>>> Kris Moore <kmoore at FreeBSD.org> writes:
>>>>
>>>>> -PORTVERSION=	0.8.3.${GITVERSION}
>>>>> -PORTEPOCH=	1
>>>>> +PORTVERSION=	0.8.4
>>>>> +PORTREVISION=	1
>>>> PORTEPOCH cannot be removed.
>>>>
>>>> $ portlint -C
>>>> FATAL: Makefile: lumina-0.8.4_1 < lumina-0.8.3.1427733141,1. Choose another PORTVERSION or bump PORTEPOCH.
>>>>
>>>>> +USE_GITHUB=     yes
>>>>> +GH_ACCOUNT=     pcbsd
>>>>> +GH_COMMIT=      01bfb64
>>>>> +GH_TAGNAME=     v0.8.4-Release-P1
>>>> GH_COMMIT is deprecated and GH_TAGNAME is often a superset of PORTVERSION.
>>>> Also, spaces instead of tabs.
>>>>
>>>> $ portlint -C
>>>> FATAL: Makefile: [43]: use a tab (not space) after a variable name
>>>> FATAL: Makefile: [44]: use a tab (not space) after a variable name
>>>> FATAL: Makefile: [45]: use a tab (not space) after a variable name
>>>> FATAL: Makefile: [46]: use a tab (not space) after a variable name
>>>>
>>>> Index: x11/lumina/Makefile
>>>> ===================================================================
>>>> --- x11/lumina/Makefile	(revision 385072)
>>>> +++ x11/lumina/Makefile	(working copy)
>>>> @@ -3,7 +3,9 @@
>>>>  
>>>>  PORTNAME=	lumina
>>>>  PORTVERSION=	0.8.4
>>>> -PORTREVISION=	1
>>>> +DISTVERSIONPREFIX=v
>>>> +DISTVERSIONSUFFIX=-Release-P1
>>>> +PORTEPOCH=	1
>>>>  CATEGORIES=	x11
>>>>  
>>>>  MAINTAINER=	kmoore at FreeBSD.org
>>>> @@ -40,10 +42,8 @@ USE_LDCONFIG=	yes
>>>>  USE_QT5=	core gui network svg linguist multimedia imageformats \
>>>>  		buildtools x11extras
>>>>  USES=		qmake tar:bzip2
>>>> -USE_GITHUB=     yes
>>>> -GH_ACCOUNT=     pcbsd
>>>> -GH_COMMIT=      01bfb64
>>>> -GH_TAGNAME=     v0.8.4-Release-P1
>>>> +USE_GITHUB=	yes
>>>> +GH_ACCOUNT=	pcbsd
>>>>  
>>>>  QMAKE_ARGS=	CONFIG+="configure"
>>>>  
>>>> Index: x11/lumina/distinfo
>>>> ===================================================================
>>>> --- x11/lumina/distinfo	(revision 385072)
>>>> +++ x11/lumina/distinfo	(working copy)
>>>> @@ -1,2 +1,2 @@
>>>> -SHA256 (lumina-0.8.4.tar.bz2) = 311114964e900132a09e9acac46958da09d7ffb12a3e1d7653147b8952f658f0
>>>> -SIZE (lumina-0.8.4.tar.bz2) = 23261871
>>>> +SHA256 (pcbsd-lumina-v0.8.4-Release-P1_GH0.tar.bz2) = 5d54f60a534ea8d92259a6f57074173d9721492b7148a5fa5bcf8894beeffaf6
>>>> +SIZE (pcbsd-lumina-v0.8.4-Release-P1_GH0.tar.bz2) = 23261876
>>> 100% agree with Jan + remove tar:bzip2 github only provides tar.gz even is you
>>> do ask a bzip2 :)
>>>
>>> Best regards,
>>> Bapt
>> Fixing it now. Don't know why I didn't see the GH_COMMIT error. My tree
>> is about a week and half old? Did that warning just go in?
>>
>>
>> -- 
>> Kris Moore
>> PC-BSD Software / iXsystems
>> Enterprise Storage & Servers Driven By Open Source
>>
> Do you have DEVELOPER=yes in your make.conf
>
> Best regards,
> Bapt

And therein lies the problem, I had cleaned out my make.conf a bit to
thoroughly.

Thanks for the heads up!

-- 
Kris Moore
PC-BSD Software / iXsystems
Enterprise Storage & Servers Driven By Open Source