svn commit: r370411 - head/sysutils/e2fsprogs

[Bryan Drewery]

On 10/7/2014 7:36 PM, Bryan Drewery wrote:
> On 10/7/2014 6:43 PM, Matthias Andree wrote:
>> Author: mandree
>> Date: Tue Oct  7 23:43:46 2014
>> New Revision: 370411
>> URL: https://svnweb.freebsd.org/changeset/ports/370411
>> QAT: https://qat.redports.org/buildarchive/r370411/
>>
>> Log:
>>   Mark broken everywhere, upstream bug (already reported).
>>   To avoid PORTEPOCH/rollback-and-forth-again, let's give upstream a few
>>   days for a fix before rolling back to 1.42.10.
> 
> This is horrible. We're providing no packages for any branch now to
> avoid bumping a metadata counter?
> 
> 

Unfortunately poudriere does not care that this is BROKEN. It reads
PKGVERSION, sees it is newer, deletes the old package, then finally
finds it should IGNORE it.

A bug in poudriere sure.

> 
>>   
>>   Added a comment to Makefile:
>>   
>>   # Regression that apparently causes use-after-free in·
>>   # http://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/?h=maint&id=47fee2ef6a23ae06f680336ffde57caa64604a4c
>>   # and can be reproduced under MALLOC_OPTIONS=J regime on 9.3-amd64, or
>>   # alternatively confirmed with valgrind, was reported upstream.
>>   #
>>   # Let's wait until 2014-10-15 whether upstream provides a fix,
>>   # else we'll bump PORTEPOCH and roll back to 1.42.10;
>>   # 1.42.11 is also faulty.
>>
>> Modified:
>>   head/sysutils/e2fsprogs/Makefile
>>
>> Modified: head/sysutils/e2fsprogs/Makefile
>> ==============================================================================
>> --- head/sysutils/e2fsprogs/Makefile	Tue Oct  7 23:26:28 2014	(r370410)
>> +++ head/sysutils/e2fsprogs/Makefile	Tue Oct  7 23:43:46 2014	(r370411)
>> @@ -53,10 +53,6 @@ USES+=		gettext iconv:build
>>  
>>  .include <bsd.port.pre.mk>
>>  
>> -.if ${OSVERSION} >= 1100000
>> -BROKEN=		Segfaults and miscalculations observed on redports
>> -.endif
>> -
>>  .if ${PORT_OPTIONS:MNLS}
>>  PLIST_SUB=	NLS=""
>>  . if empty(ICONV_LIB)
>> @@ -84,6 +80,16 @@ post-patch::
>>  .endfor
>>  
>>  .if ${MASTERDIR} == ${.CURDIR}
>> +# Regression that apparently causes use-after-free in 
>> +# http://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/?h=maint&id=47fee2ef6a23ae06f680336ffde57caa64604a4c
>> +# and can be reproduced under MALLOC_OPTIONS=J regime on 9.3-amd64, or
>> +# alternatively confirmed with valgrind, was reported upstream.
>> +#
>> +# Let's wait until 2014-10-15 whether upstream provides a fix,
>> +# else we'll bump PORTEPOCH and roll back to 1.42.10;
>> +# 1.42.11 is also faulty.
>> +BROKEN=		Use-after-free bug, see ${.CURDIR}/Makefile comments for details
>> +
>>  pre-build:
>>  # fix up Makefile ordering for parallel builds
>>  	cd ${WRKSRC}/lib/et && ${DO_MAKE_BUILD} compile_et
>>
> 
> 


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20141007/324319ee/attachment.sig>