svn commit: r370131 - in head/net-mgmt: . nagios-check_dhcp.pl

[John Marino]

On 10/6/2014 05:35, Andrej Zverev wrote:
> 2. @${REINPLACE_CMD} -e "s,/usr/bin/perl,${PERL}," ${WRKSRC}/${PORTNAME}
> <- you can use USES=shebangfix

Be careful with this one -- I made a similar comment and then found out
the script started with "#! /usr/bin/perl" where the space prevented
shebangfix from working.  This could be a similar situation.

> P.S.  Approved by:  mentors (implicit) <- not sure about this  they both
> did it, or only one of them and why don't write who they are?

Robak has implicit approval from both mentors for most commits.  He's
been given guidelines on when he should seek explicit approval.  I'd
says "mentors" (plural) is appropriate.

As for why not written, dunno.  Obviously it can be looked up.  I think
the key message is that explicit approval was not obtained, not
repeating who the mentors are which each commit (which doesn't change).
 As one of his mentors, I didn't have a problem with the message.