svn commit: r373458 - in head/www: linux-c6-flashplugin11 linux-f10-flashplugin11

[John Marino]

On 11/27/2014 09:21, Tijl Coosemans wrote:
> On Wed, 26 Nov 2014 21:20:13 +0100 John Marino <freebsd.contact at marino.st> wrote:
>> On 11/26/2014 21:14, Tijl Coosemans wrote:
>>> On Wed, 26 Nov 2014 19:48:24 +0000 (UTC) John Marino <marino at FreeBSD.org> wrote:
>>>> +%%NO_ALSA%%%%LINUXBASE%%/usr/lib/libflashsupport.so
>>>> +%%NO_ALSA%%@dir %%LINUXBASE%%/usr/lib
>>>> +%%NO_ALSA%%@dir %%LINUXBASE%%/usr
>>>> +%%NO_ALSA%%@dir %%LINUXBASE%%
>>>> +%%NO_ALSA%%@dir %%COMPATDIR%%
>>>
>>> Traditionally /compat is a symlink to /usr/compat, so I'm not sure it's
>>> safe to delete it like this.  But even if it is this port depends on
>>> emulators/linux_base so none of these @dir are necessary.
>>
>> The port was creating empty directories in stagedir when ALSA option is
>> off.  So at least in one case, they are necessary (or deleting from
>> stagedir is necessary).  Nothing is getting deleted.
> 
> The directory %%LINUXBASE%%/usr/lib isn't empty.  It contains
> libflashsupport.so.  And that directory belongs to emulators/linux_base
> so this port does not have to list it with @dir.


So at worst it's a no-op, right?  pkg won't create a directory if it
already exists - and won't delete if it's still contains files.

make check-plist was coming back with *errors*.  I don't want to accept
errors as normal.  No port should fail -t checks in poudriere.  Do you
know a better solution that doesn't result in make check-plist failure?

Perhaps removing the directories from stagedir instead?

John