svn commit: r365735 - in head/games: . prboom-plus

[Adam Weinberger]

On 25 Aug, 2014, at 5:32, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:

> On Sat, Aug 23, 2014 at 02:04:13PM +0000, Adam Weinberger wrote:
>> New Revision: 365735
>> URL: http://svnweb.freebsd.org/changeset/ports/365735
>> QAT: https://qat.redports.org/buildarchive/r365735/
>> 
>> @@ -0,0 +1,43 @@
>> +# Created by: Jordan DeLong <fracture at allusion.net>
>> +# $FreeBSD$
>> +
>> +PORTNAME=	prboom-plus
>> +PORTVERSION=	2.5.1.3
>> +CATEGORIES=	games
>> +MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTVERSION}
>> +
>> +MAINTAINER=	thiagohero501 at gmail.com
>> +COMMENT=	A fork of the doom game engine prboom
> 
> COMMENT line is wrong. :)

Because it starts with an article? I’d posit that that article improves readability of this particular COMMENT.

> 
>> Added: head/games/prboom-plus/Makefile.include
>> ==============================================================================
>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>> +++ head/games/prboom-plus/Makefile.include	Sat Aug 23 14:04:12 2014	(r365735)
>> @@ -0,0 +1,24 @@
>> +# Makefile for defining variables used by other Doom related ports.
>> +
>> +DMPKGNAMEPREFIX?=	doom-
>> +DMDIR?=		${LOCALBASE}/share/doom
>> +
>> +.if defined(PKGNAMEPREFIX) && ${PKGNAMEPREFIX} == ${DMPKGNAMEPREFIX} && defined(OPTIONSMKINCLUDED)
>> +.  error include before <bsd.port.options.mk> if using DMPKGNAMEPREFIX
>> +.endif
>> +
>> +MAKE_ENV+=	DMDIR="${DMDIR}"
>> +PLIST_SUB+=	DMDIR="${DMDIR:S/${LOCALBASE}\///}"
>> +SUB_LIST+=	DMDIR="${DMDIR}"
>> +
>> +.if defined(USE_CRLF)
>> +.   if defined(USE_ZIP)
>> +EXTRACT_BEFORE_ARGS=	-aqo
>> +.   else
>> +pre-patch:
>> +	@${FIND} ${WRKDIR} -type f -print0 | \
>> +		${XARGS} -0 ${FILE} | ${GREP} 'CRLF' | \
>> +		${SED} -e "s/:.*//" | ${SED} -e 's/ /\\ /g' | \
>> +		${XARGS} ${REINPLACE_CMD} -i "" -e "s/`${PRINTF} '\r'`$$//"
>> +.   endif
>> +.endif
> 
> This looks like the old version of the doom-data/Makefile.include file.  Why
> it was copied here.  Submitter should've taken a look at other Doom ports to
> see how to properly use this file.

> I’m aware, and I noted it in the PR. Some the stuff in there is useless, and I removed even more nonsense out of what was originally submitted, but some of it actually does stuff, so I decided, why the hell not.

Feel free to rip it out and clean it up if you’d like.

> It would be nice to have this patch first reviewed by games at .

After spending a lot of time fixing endless build failures, preventing things from controlling examples with DOCS, and sending emails to mailing lists and never getting replies, I’ve come to the conclusion that hat groups are largely for show. I cannot tell you how much I’d love to be proven wrong. It’s hard to know which hat groups are active, and which just collects ports and hope someone else will fix them for them.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org