svn commit: r365639 - head/Mk

Alexey Dokuchaev danfe at FreeBSD.org
Fri Aug 22 12:10:30 UTC 2014


On Fri, Aug 22, 2014 at 11:31:35AM +0000, Sunpoet Po-Chuan Hsieh wrote:
> New Revision: 365639
> URL: http://svnweb.freebsd.org/changeset/ports/365639
> QAT: https://qat.redports.org/buildarchive/r365639/
> 
> Log:
>   - Add shared JSON_C description
> [...]
> @@ -164,6 +164,7 @@ JAVA_DESC?=		Java platform support
>  JBIG_DESC?=		JBIG image format support
>  JHEAD_DESC?=		jhead EXIF manipulator support
>  JPEG_DESC?=		JPEG image format support
> +JSON_C_DESC?=		JSON file/format parser support via json-c
>  JSON_DESC?=		JSON file/format/parser support

This looks like of weird.  Do you anticipate ports that will have to use
both of these options?  If not, I don't see why you cannot simply (re)use
nice and clear JSON for both json/json-c.  Options were never meant to
always directly map to some library.  Yes, sometimes they do, but this is
still different layer of abstraction.

./danfe


More information about the svn-ports-head mailing list