svn commit: r364518 - in head: accessibility/py-papi audio/py-al devel/py-astroid devel/py-dynrules devel/py-game devel/py-logilab-common devel/py-ocempgui devel/py-ply devel/py-sdl2 devel/pychecke...

Alexey Dokuchaev danfe at FreeBSD.org
Sun Aug 10 16:44:16 UTC 2014


On Sun, Aug 10, 2014 at 03:40:11PM +0000, Max Brazhnikov wrote:
> On Sun, 10 Aug 2014 09:55:16 +0000 Alexey Dokuchaev wrote:
> > On Sun, Aug 10, 2014 at 08:55:08AM +0000, Marcus von Appen wrote:
> > > New Revision: 364518
> > > URL: http://svnweb.freebsd.org/changeset/ports/364518
> > > QAT: https://qat.redports.org/buildarchive/r364518/
> > > 
> > > -USES=		pkgconfig
> > > +USES=		pkgconfig python:2
> > >  USE_GNOME=	atk
> > > -USE_PYTHON=	2
> > > -USE_PYDISTUTILS=yes
> > > -PYDISTUTILS_AUTOPLIST=	yes
> > > +PYTHON_FEATURES=autoplist distutils
> > 
> > Yuck, this PYTHON_FEATURES knob is ugly.  Why not follow Perl's example
> > instead (USES=perl and USE_PERL)?  It both makes more sense and shorter.
> 
> ugly or not, it's a matter of taste. [...]

Not really.  It is also 1) inconsistent with USE_PERL, and 2) is overly
long knob name (breaks indentation).

./danfe

P.S.  I'm wondering about these "a matter of taste" reasons.  Are you
guys really don't see the ugliness when it's there?  Why defending it
when it can/should be just fixed?


More information about the svn-ports-head mailing list