svn commit: r363361 - in head/editors/fte: . files

John Marino freebsd.contact at marino.st
Fri Aug 1 06:41:17 UTC 2014


On 8/1/2014 08:32, Alexey Dokuchaev wrote:
> On Fri, Aug 01, 2014 at 08:25:44AM +0200, John Marino wrote:
>> On 8/1/2014 08:20, Alexey Dokuchaev wrote:
>>> Basically right now one patch will overwrite another conflicting one, which
>>> ever comes first.  I think I can add a check beforea > $${OUT} and issue an
>>> error and refuse to overwrite a file, or maybe just warn.  Which you prefer?
>>
>> Neither.  I prefer the original character escaped with itself  You may
>> not like this, but something like: [...]
> 
> You're right, I don't. :-)  However, I will implement autoexpantion (char
> -> charchar) since it doesn't add too much complexity.
> 
>> Thoughts?  any potential of overwritting is bad.
> 
> Well, my original idea (bail out with an error) is how I saw we prevent
> overwriting: by asserting that output file does not exist; you think it is
> not robust enough?

No, because you don't cover the case where both files legitimately need
patching.  Why bail out with error when I *want* both patches to exist?
 You are forcing me to rename one?  to what?

I've been using "_" => "__" for a while now, it's not bad.  Yes, double
underscore remains but a very low frequency.  The main issue is that it
represents a different character ("_") than it does now ("\").

John


More information about the svn-ports-head mailing list