svn commit: r326253 - head/games/p5-Games-Dice

[Jason Helfman]

On Wed, Sep 4, 2013 at 8:51 PM, Sunpoet Po-Chuan Hsieh
<sunpoet at freebsd.org>wrote:

> On Thu, Sep 5, 2013 at 11:47 AM, Jason Helfman <jgh at freebsd.org> wrote:
>
>> On Wed, Sep 4, 2013 at 8:29 AM, Sunpoet Po-Chuan Hsieh
>> <sunpoet at freebsd.org>wrote:
>>
>> > On Wed, Sep 4, 2013 at 2:59 PM, Andrej Zverev <az at freebsd.org> wrote:
>> >
>> >> On Wed, Sep 4, 2013 at 10:46 AM, Jason Helfman <jgh at freebsd.org>
>> wrote:
>> >> > Author: jgh
>> >> > Date: Wed Sep  4 06:46:23 2013
>> >> > New Revision: 326253
>> >> > URL: http://svnweb.freebsd.org/changeset/ports/326253
>> >> >
>> >> > Log:
>> >> >   - update to 0.043
>> >> >   - adoption of perl USES framework
>> >> >   - adjust dependencies
>> >> >
>> >> >   PR:           181770
>> >> >   Submitted by: danilogondolfo at gmail.com ( maintainer )
>> >> >
>> >>
>> >> >
>> >> > +BUILD_DEPENDS= p5-Capture-Tiny>=0:${PORTSDIR}/devel/p5-Capture-Tiny
>> \
>> >> > +
>> p5-Test-Script>=1.06:${PORTSDIR}/devel/p5-Test-Script \
>> >> > +               p5-Test-Simple>=0.96:${PORTSDIR}/devel/p5-Test-Simple
>> >>
>> >> We try not to add to the Test:: namespace into (RUN|BUILD)_DEPENDS for
>> >> p5- and what you need only for the tests (t/*). In this case, I do not
>> >> see why it's done.
>> >>
>> >
>> > These three perl modules are all test-only dependencies. We have
>> > TEST_DEPENDS [1] for this purpose. At least tinderbox recognizes it.
>> >
>> > [1] https://wiki.freebsd.org/Perl#Test_Dependencies
>> >
>>
>> Originally, I had thought about adding these in as TEST_DEPENDS, but found
>> it wasn't documented anywhere in ports framework, or the handbook.
>> That being said, buildlogs for the port, itself, also showed failure on an
>> incomplete kit using pourdiere. I don't know if this is expected, or if
>> this is an issue with configuration of the software for a build mode vs. a
>> test mode.
>>
>> How does this diff look?
>>
>> -jgh
>>
>> Index: games/p5-Games-Dice/Makefile
>> ===================================================================
>> --- games/p5-Games-Dice/Makefile    (revision 326340)
>> +++ games/p5-Games-Dice/Makefile    (working copy)
>> @@ -3,6 +3,7 @@
>>
>>  PORTNAME=    Games-Dice
>>  PORTVERSION=    0.043
>> +PORTREVISION=    1
>>  CATEGORIES=    games perl5
>>  MASTER_SITES=    CPAN
>>  PKGNAMEPREFIX=    p5-
>> @@ -12,7 +13,7 @@
>>
>>  LICENSE=    MIT
>>
>> -BUILD_DEPENDS=    p5-Capture-Tiny>=0:${PORTSDIR}/devel/p5-Capture-Tiny \
>> +TEST_DEPENDS=    p5-Capture-Tiny>=0:${PORTSDIR}/devel/p5-Capture-Tiny \
>>          p5-Test-Script>=1.06:${PORTSDIR}/devel/p5-Test-Script \
>>          p5-Test-Simple>=0.96:${PORTSDIR}/devel/p5-Test-Simple
>>
>>
> It's ok. BTW, you don't need to bump PORTREVISION if there's only
> BUILD_DEPENDS changes.
>
> Regards,
> sunpoet
>
>
 I thought with the removal of the dependencies that it would warrant a
bump, however in reading over the handbook, it seems unnecessary.

Thanks!

-jgh