svn commit: r326241 - head/math/octave-forge-odepkg

[Stephen Montgomery-Smith]

On 09/03/2013 10:30 PM, Alexey Dokuchaev wrote:
> On Wed, Sep 04, 2013 at 01:38:17AM +0000, Stephen Montgomery-Smith wrote:
>> New Revision: 326241
>> URL: http://svnweb.freebsd.org/changeset/ports/326241
>>
>> Log:
>>   - Set make_jobs_unsafe, otherwise patches can get applied out of order.

With this particular port, I am not quite sure exactly what goes wrong.
 But at some point, it applies a whole bunch of patches within its
Makefile.  And I was getting "patch already applied" errors.  Something
was being done out of order - maybe it wasn't specifically the
application of the patches.

> 
> Do you see any better solution to this?  Maybe force the order somehow?
> MAKE_JOBS_UNSAFE should be used as a last resort, when problem cannot be
> easily fixed.
> 
> ./danfe (dreaming of 100% jobs-safe ports tree :)

I probably could try to find a fix (but I'll have to read up on how
gmake performs its -j operations first).

However, from a philosophical point of view, if a project external to
FreeBSD makes source code that is not safe for the -j option to be used,
should FreeBSD ports committers feel that it is our job to correct their
source code?

I think the answer should be "no," and it seems you disagree.  I would
like to hear what other people think.