svn commit: r330725 - in head/games/heretic: . files

John Marino freebsd.contact at marino.st
Fri Oct 18 08:10:56 UTC 2013


On 10/18/2013 09:59, Oliver Lehmann wrote:
> 
> Baptiste Daroussin <bapt at freebsd.org> wrote:
> 
>> On Fri, Oct 18, 2013 at 07:05:40AM +0000, Oliver Lehmann wrote:
> 
>>> [...]
>>> +-CC = gcc
>>> ++#CC = gcc
>>> [...]
> 
>>
>> Passing CC and CFLAGS to MAKE_ARGS will achieve the same goal without
>> the need
>> of an external patch.
>>
>> MAKE_ARGS= CC="${CC}" CFLAGS="${CFLAGS}"
> 
> Please reread my patch - I snipped it to the important part. ;)
>

Oliver,
As I understand it, the original line only defines CC to "gcc" if CC is
not present in the MAKE_ARGS.  Thus bapt is correct, you don't need to
patch this line.

(In BSD make, it would be CC?=gcc, but gmake looks at MAKE_ARGS)

John


More information about the svn-ports-head mailing list