svn commit: r334593 - in head/dns: bind96 bind96/files bind98 bind98/files bind99 bind99/files

[Alexey Dokuchaev]

On Tue, Nov 26, 2013 at 08:38:52AM +0100, Baptiste Daroussin wrote:
> On Tue, Nov 26, 2013 at 03:53:39AM +0000, Alexey Dokuchaev wrote:
> > Given that OSVERSION is used extensively in the tree, I'm worrying that
> > adding these extra "${OPSYS} == FreeBSD" checks will our makefiles less
> > readable.  Wouldn't it make more sense to place this check somewhere in
> > single place, and define whatever OSVERSION that looks reasonable when
> > OPSYS == FreeBSD instead of patching every port?
> 
> except that lots/most of the osversion checking in the ports tree is also
> wrong and was due to a design bug of pointyhat/tinderbox, pointyhat is gone,
> and tinderbox had been fixed. there is no need anymore for most of them
> which also are often wrong given the flexibility we have with buildworld.
> 
> I do plan to remove most of the useless osversion.

Yup, I remember this was discussed on IRC a few times.  I'm only looking
forward to it.  However, introducing "${OPSYS} == FreeBSD" checks in, uhm,
*FreeBSD* ports collection looks bogus to me.  If <whatever>BSD wants to
make use of it, fine, but please let's keep their little hacks outside of
FreeBSD ports. :)

./danfe