svn commit: r334593 - in head/dns: bind96 bind96/files bind98 bind98/files bind99 bind99/files

Alexey Dokuchaev danfe at FreeBSD.org
Tue Nov 26 03:53:39 UTC 2013


On Sun, Nov 24, 2013 at 10:37:01AM +0100, John Marino wrote:
> I have attached a diff with the proposed changes covering all three
> ports.  It's pretty straight-forward.
>  
>  .if ${PORT_OPTIONS:MREPLACE_BASE}
> -.if ${OSVERSION} >= 1000500
> +.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1000500

Given that OSVERSION is used extensively in the tree, I'm worrying that
adding these extra "${OPSYS} == FreeBSD" checks will our makefiles less
readable.  Wouldn't it make more sense to place this check somewhere in
single place, and define whatever OSVERSION that looks reasonable when
OPSYS == FreeBSD instead of patching every port?

./danfe


More information about the svn-ports-head mailing list