svn commit: r332567 - head/graphics/apvlv

[Mark Felder]

On Sun, Nov 3, 2013, at 13:38, Eitan Adler wrote:
> On Sun, Nov 3, 2013 at 2:14 PM, Tijl Coosemans <tijl at freebsd.org> wrote:
> 
> > but now PTHREAD_CFLAGS is always empty
> 
> Which is always a mistake.  PTHREAD_CFLAGS should be replaced with
> -pthread
> 
>  so you can remove that line and PTHREAD_LIBS is always
> > -pthread.
> 
> As should this.
> 

Thanks for the feedback guys. Perhaps we should put PTHREAD_CFLAGS and
PTHREAD_LIBS into portlint as well.

I'm not 100% sure I understand the changes you're proposing -- I'm
getting caught up on the wording. Is this diff what you're suggesting?

--- Makefile    (revision 332703)
+++ Makefile    (working copy)
@@ -22,8 +22,8 @@
                -DDOCDIR=${DOCSDIR} \
                -DAPVLV_WITH_UMD=OFF \
                -DAPVLV_WITH_TXT=ON
-CFLAGS+=       ${PTHREAD_CFLAGS}
-LDFLAGS+=      ${PTHREAD_LIBS}
+CFLAGS+=       -pthread
+LDFLAGS+=      -pthread
 
 OPTIONS_DEFINE=        DJVU WEBKIT